From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C81A745940 for ; Mon, 8 Apr 2024 11:32:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712575974; cv=none; b=YoGU0LdI3xGHfxbhkNswGGjAgllqQ2KKapz/m+1GqDE5dxsyZczl7UV7ixTsK9f9rnw7TxRuCklofRNMOeNBLlyFIll5SddoH1I7A+WBkl1oV6crmMyZTGI+/Lt09l5LOA6CZRSOHH7OOubXazvpKOAzr0EkVNqYJxCaFoqZYRk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712575974; c=relaxed/simple; bh=VmzuN/oIVgAfQmhDb7JLOrkVWqx+M5AEzMX8qMZn+jw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HL/1EMDshEYfpo9//1GP7iWojpt+l8oaVFjFOndVeBHkZCs20qhr8dHVf5auAab+CFmXRlMdi/CtdqjzJXwTPLAtuEuSXOXpW9ktTScjQT3CRwDvSAImf0qwbt95etbusfxkcpZY18RvmeNhqIIO6fwAEvbrtlAOyXTw7ln+QVs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=g5op16r0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="g5op16r0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA900C433C7; Mon, 8 Apr 2024 11:32:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712575974; bh=VmzuN/oIVgAfQmhDb7JLOrkVWqx+M5AEzMX8qMZn+jw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g5op16r0aIWq4YeJzab7IMtCXct1lZ6v5DKlVeBj/qvU5xAxltvw+KM2mqIbukp+l FM15vzzw6TfFGyf3RVeiSWuPMfHx7ODgKk8yU3R+kXuCFKZEx0jYffL1AQn+mj18R2 bUoTaKcB1B/YCrGBuvkNWCIBHqT27+3+XcD7Knys= Date: Mon, 8 Apr 2024 13:32:51 +0200 From: Greg Kroah-Hartman To: Tokunori Ikegami Cc: linux-nvme@lists.infradead.org, stable@vger.kernel.org, "min15.li" , Kanchan Joshi , Christoph Hellwig , Keith Busch Subject: Re: [PATCH for 5.15.y] nvme: fix miss command type check Message-ID: <2024040844-papyrus-bronco-693b@gregkh> References: <20240407091528.5025-1-ikegami.t@gmail.com> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240407091528.5025-1-ikegami.t@gmail.com> On Sun, Apr 07, 2024 at 06:15:28PM +0900, Tokunori Ikegami wrote: > From: "min15.li" > > commit 31a5978243d24d77be4bacca56c78a0fbc43b00d upstream. > > In the function nvme_passthru_end(), only the value of the command > opcode is checked, without checking the command type (IO command or > Admin command). When we send a Dataset Management command (The opcode > of the Dataset Management command is the same as the Set Feature > command), kernel thinks it is a set feature command, then sets the > controller's keep alive interval, and calls nvme_keep_alive_work(). > > Signed-off-by: min15.li > Reviewed-by: Kanchan Joshi > Reviewed-by: Christoph Hellwig > Signed-off-by: Keith Busch > Fixes: b58da2d270db ("nvme: update keep alive interval when kato is modified") > Signed-off-by: Tokunori Ikegami > --- > drivers/nvme/host/core.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Both now queued up, thanks. greg k-h