From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9060146A64; Thu, 11 Apr 2024 10:26:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712831163; cv=none; b=EXJ2GSVfWmnWNPlgYiybVMoKe9qcjGJLdnyzCelVrhVl2QGmq8+Wzj3o+R9JkNjN9yWhVCltLNhHRmQVlHXtqNzPfD4TES0iMKUHc72YI4JaPOLfSYXruoP1xuMfJ+BX24ri0y8Zil/XjKJGe98ShZ6oK0KS45KGmGt+Ur5BOQI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712831163; c=relaxed/simple; bh=I4hA93/j6qYoK5/1DuV8IXQy1756FXFYYM6AtqQNncY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=h/GmhI3YZYwY+9nTU1pNrruL2DGhzDTRGLhOhygrzuNuD7H0WRS2zJznsVtbIsquhbHKusI1zctghKv/IoHAFDbOAo1WAG+gwFOd+3vN2IvCZwpO7OpHlPBYRlNqMw23eJZjhvYPrS2HHfovzX2rKB2RPMU3PNpi7EQTrWg6SDs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pqewzqOc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pqewzqOc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C3F3C433C7; Thu, 11 Apr 2024 10:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712831163; bh=I4hA93/j6qYoK5/1DuV8IXQy1756FXFYYM6AtqQNncY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pqewzqOc4T1rXv+dUkXQwtVMOI2l58fXQTqLcTgNjbO6fGZdQivTqYaWYMo/QFP72 phmImkj97bzsQIqaCfxlEUsV9E10MyRPlU1zZOSQ2tH9RPFiceg6ttUsgmTur921U5 gM7d3WSdORrNGQ12RE+JecUlEHPqf09YtNAS2A/I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Samasth Norway Ananda , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 6.6 030/114] tools/power x86_energy_perf_policy: Fix file leak in get_pkg_num() Date: Thu, 11 Apr 2024 11:55:57 +0200 Message-ID: <20240411095417.779298059@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240411095416.853744210@linuxfoundation.org> References: <20240411095416.853744210@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Samasth Norway Ananda [ Upstream commit f85450f134f0b4ca7e042dc3dc89155656a2299d ] In function get_pkg_num() if fopen_or_die() succeeds it returns a file pointer to be used. But fclose() is never called before returning from the function. Signed-off-by: Samasth Norway Ananda Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c index 5fd9e594079cf..ebda9c366b2ba 100644 --- a/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c +++ b/tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c @@ -1241,6 +1241,7 @@ unsigned int get_pkg_num(int cpu) retval = fscanf(fp, "%d\n", &pkg); if (retval != 1) errx(1, "%s: failed to parse", pathname); + fclose(fp); return pkg; } -- 2.43.0