From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63F8114532F; Thu, 11 Apr 2024 10:03:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712829803; cv=none; b=u0SUF4znecJeoyvYHfNoWNltyGZuIS2JP98ndj8yyBcAgRbpQss9gBIljoC6ta0mL6kgxI0gEykUCFokDa+JSb0PBU3BAJCHK0iMqX+jrPpwO0xCxzqA5pOBlLRQhmhxfbTbmHBF6XkTQtrMt9GpStSiZr84pSzy0JtwSFVF6pw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712829803; c=relaxed/simple; bh=RfTQQXnAUYVg1yrWumFjor8u2e48qfNt1oH1zpbQo1I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iTd20UXsUgXMooDG4+xCxuPBFNwyhhJMLEykNZt45M02iPRbzIXTF1lNGnrB8eP95Z3AJk+pv+d99xhulzH1gC6yu9nVQpiVe6Y13qpqydfYTiqsZJWAJqPgqu90Twj2WUqC4P5zf4zkO5H3QhCFliMA6tfOOT24lFmk/SDcljY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2BG8GuAL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2BG8GuAL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 588AFC433C7; Thu, 11 Apr 2024 10:03:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712829802; bh=RfTQQXnAUYVg1yrWumFjor8u2e48qfNt1oH1zpbQo1I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2BG8GuAL0l5zVijMXRiD+FNOPW17tFLBgKj4mBUG4oXC9wwmM+LUSLqD8vxh8KyNG K4IgL/Tc0oxPdl7A6HlnhZqS79gxN58V4MrLbZ+qBsE0xvXRG0ffe0MCESaBb3uksb /N8P9picUnFnaE7YheYW9lqZlNkjMTZcwzztkRX4= From: Greg Kroah-Hartman To: stable@vger.kernel.org, dri-devel@lists.freedesktop.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Christoph Niedermaier , Marek Vasut , Boris Brezillon , Philipp Zabel , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, Max Krummenacher , Maarten Lankhorst Subject: [PATCH 4.19 109/175] drm/imx: parallel-display: Remove bus flags check in imx_pd_bridge_atomic_check() Date: Thu, 11 Apr 2024 11:55:32 +0200 Message-ID: <20240411095422.849076905@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240411095419.532012976@linuxfoundation.org> References: <20240411095419.532012976@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Christoph Niedermaier commit 6061806a863e8b65b109eb06a280041cc7525442 upstream. If display timings were read from the devicetree using of_get_display_timing() and pixelclk-active is defined there, the flag DISPLAY_FLAGS_SYNC_POSEDGE/NEGEDGE is automatically generated. Through the function drm_bus_flags_from_videomode() e.g. called in the panel-simple driver this flag got into the bus flags, but then in imx_pd_bridge_atomic_check() the bus flag check failed and will not initialize the display. The original commit fe141cedc433 does not explain why this check was introduced. So remove the bus flags check, because it stops the initialization of the display with valid bus flags. Fixes: fe141cedc433 ("drm/imx: pd: Use bus format/flags provided by the bridge when available") Signed-off-by: Christoph Niedermaier Cc: Marek Vasut Cc: Boris Brezillon Cc: Philipp Zabel Cc: David Airlie Cc: Daniel Vetter Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: linux-arm-kernel@lists.infradead.org To: dri-devel@lists.freedesktop.org Tested-by: Max Krummenacher Acked-by: Boris Brezillon Signed-off-by: Marek Vasut Link: https://patchwork.freedesktop.org/patch/msgid/20220201113643.4638-1-cniedermaier@dh-electronics.com Signed-off-by: Maarten Lankhorst Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/imx/parallel-display.c | 8 -------- 1 file changed, 8 deletions(-) --- a/drivers/gpu/drm/imx/parallel-display.c +++ b/drivers/gpu/drm/imx/parallel-display.c @@ -235,14 +235,6 @@ static int imx_pd_bridge_atomic_check(st if (!imx_pd_format_supported(bus_fmt)) return -EINVAL; - if (bus_flags & - ~(DRM_BUS_FLAG_DE_LOW | DRM_BUS_FLAG_DE_HIGH | - DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE | - DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE)) { - dev_warn(imxpd->dev, "invalid bus_flags (%x)\n", bus_flags); - return -EINVAL; - } - bridge_state->output_bus_cfg.flags = bus_flags; bridge_state->input_bus_cfg.flags = bus_flags; imx_crtc_state->bus_flags = bus_flags;