From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4785A1465AA; Thu, 11 Apr 2024 10:10:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712830237; cv=none; b=WBd89hnOUW81wNhE9D17yaAxpS6q+j4YUc8r2mTbTsnOzwzGFLqKSzt/l8/CTFcLwrVLuYyX00tTLT3Hp7RWTVAofx80I+7U8Y6cX9ePWIUYaNygUx4PSPLAR4mwYz0ZdV4wcGRK0MF1YeE6RLcHZ3LID4EE5wQkjK2zWUtK1G4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712830237; c=relaxed/simple; bh=6t/TIUSO2HFYe6h2u7r5R6IRIaMm73adXDH/rPoZegg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FNxKnyGkAUw+VAvxKKDF6RkIRZPFXuBJrpQt/rsfXOaySqutDHKVF8ixFY54CI/RGmYFDkHxoDE3KrKj4GdFeWqhmBsws+KhKxOAKxM2ovwiF34JKwi/rn4tZVMI6y3VIb9EpB0N+QzPnaBIykuKYXpOD6xFxXOLqmBjEodbAow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=HkykznWW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HkykznWW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1F60C433F1; Thu, 11 Apr 2024 10:10:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712830237; bh=6t/TIUSO2HFYe6h2u7r5R6IRIaMm73adXDH/rPoZegg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HkykznWWEANBfcDQvKblORnoUj3foBYIL+r8CvnZm3w4t8Tw6lwabPGBPGvko0rgZ 3gduYCqrfXW3LN7TfuchmCgC2FUs5NJQ2AWrV8O3xRLPirPOH+cv1fPGjkEf1IducF McRFFlQCOm2mRQXmCo852V3BPzUrX6NqdkH7K02c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zhang Yi , Jan Kara , Theodore Tso , Sasha Levin Subject: [PATCH 6.8 081/143] ext4: add a hint for block bitmap corrupt state in mb_groups Date: Thu, 11 Apr 2024 11:55:49 +0200 Message-ID: <20240411095423.351758426@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240411095420.903937140@linuxfoundation.org> References: <20240411095420.903937140@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.8-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhang Yi [ Upstream commit 68ee261fb15457ecb17e3683cb4e6a4792ca5b71 ] If one group is marked as block bitmap corrupted, its free blocks cannot be used and its free count is also deducted from the global sbi->s_freeclusters_counter. User might be confused about the absent free space because we can't query the information about corrupted block groups except unreliable error messages in syslog. So add a hint to show block bitmap corrupted groups in mb_groups. Signed-off-by: Zhang Yi Reviewed-by: Jan Kara Link: https://lore.kernel.org/r/20240119061154.1525781-1-yi.zhang@huaweicloud.com Signed-off-by: Theodore Ts'o Signed-off-by: Sasha Levin --- fs/ext4/mballoc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 70836e25418ab..cf407425d0f30 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -3059,7 +3059,10 @@ static int ext4_mb_seq_groups_show(struct seq_file *seq, void *v) for (i = 0; i <= 13; i++) seq_printf(seq, " %-5u", i <= blocksize_bits + 1 ? sg.info.bb_counters[i] : 0); - seq_puts(seq, " ]\n"); + seq_puts(seq, " ]"); + if (EXT4_MB_GRP_BBITMAP_CORRUPT(&sg.info)) + seq_puts(seq, " Block bitmap corrupted!"); + seq_puts(seq, "\n"); return 0; } -- 2.43.0