From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD0392EAE5; Thu, 11 Apr 2024 10:05:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712829903; cv=none; b=oqMkSOiw7I5xolSZ288Gry2S+/U7fp4bawsi2udeijL+ZSq3M73G0UfRpP/fQsNb7VgXR9M0GTBAPJ1dA3X3r++BQqMRbSWJbOg6kK3wrPI1ZMf92VWrBgCUHqV2Q72Tuibm+lG0TMBfCS4zgJy01cawws+0xZcjCpQoGXjC/kM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712829903; c=relaxed/simple; bh=YXbbiZSBBLQF52vjxrE4zTTPVJoWuoFkLzJWqvaIRl4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lPMCJ59NmdrOa+uv4+EFCyh4fDONUTXb39Xtfi6Nmg48LpC34L/AorRp4jduzgYiI42R5cX2aZ/v9z2hQDSi5MOPLedyackCFyjw+VltPdOaA9dS2sy22Lean5v8XueXM7i5O9QvYPWIcxbmGwmSVopswNO98FEudqEh7Ao65CA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=HTG+P7dN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="HTG+P7dN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62E73C433C7; Thu, 11 Apr 2024 10:05:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712829902; bh=YXbbiZSBBLQF52vjxrE4zTTPVJoWuoFkLzJWqvaIRl4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HTG+P7dNsosfBquU4Nc3WfRAM3TkBZ5GZkvLiIaoO61tkgelfMiQXSjgt4Nf2cMdZ PrH3YlehyHhAKTrwIhYxaOYbxjDEr7kAqWI/bgrpps8KlMlzM7g3kGJhF+bGp7YtsL fnkujkq9egc/kBUwfRXKlj/yc3Y+mJhhM6cqYB7k= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dmitry Antipov , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Kalle Valo , Sasha Levin Subject: [PATCH 4.19 144/175] wifi: ath9k: fix LNA selection in ath_ant_try_scan() Date: Thu, 11 Apr 2024 11:56:07 +0200 Message-ID: <20240411095423.898650819@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240411095419.532012976@linuxfoundation.org> References: <20240411095419.532012976@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dmitry Antipov [ Upstream commit d6b27eb997ef9a2aa51633b3111bc4a04748e6d3 ] In 'ath_ant_try_scan()', (most likely) the 2nd LNA's signal strength should be used in comparison against RSSI when selecting first LNA as the main one. Compile tested only. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Antipov Acked-by: Toke Høiland-Jørgensen Signed-off-by: Kalle Valo Link: https://msgid.link/20231211172502.25202-1-dmantipov@yandex.ru Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath9k/antenna.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath9k/antenna.c b/drivers/net/wireless/ath/ath9k/antenna.c index a3668433dc02b..deac6184dd016 100644 --- a/drivers/net/wireless/ath/ath9k/antenna.c +++ b/drivers/net/wireless/ath/ath9k/antenna.c @@ -643,7 +643,7 @@ static void ath_ant_try_scan(struct ath_ant_comb *antcomb, conf->main_lna_conf = ATH_ANT_DIV_COMB_LNA1; conf->alt_lna_conf = ATH_ANT_DIV_COMB_LNA1_PLUS_LNA2; } else if (antcomb->rssi_sub > - antcomb->rssi_lna1) { + antcomb->rssi_lna2) { /* set to A-B */ conf->main_lna_conf = ATH_ANT_DIV_COMB_LNA1; conf->alt_lna_conf = ATH_ANT_DIV_COMB_LNA1_MINUS_LNA2; -- 2.43.0