From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E6A913F452; Thu, 11 Apr 2024 10:16:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712830581; cv=none; b=ecUvFVsxu5UdHLLBPj+CXX2vUroPyWfP3rBaczGybGUS/xRmTTlWWD17ursPa7bruP7NAGsV7b1+j6Xip714WSRA1Fe/LZggoMrSDPN7S0ejiW5WuYl8c8Z1HCrRyn9wL6sIea40nRoq9K4MU3akTU0CdEn8oPydojcWgBYuvAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712830581; c=relaxed/simple; bh=7LHc9cDRJKpfK4Pb8QXkAZQ8s39wOtwz18WlOgKNOBk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SB1488EJS6qCO4KeDXGW8NrpkBKCZ4p1JmjHyVIRDv4Jn0YMDV88fijEZlkhf8a02IMddrT/PSkp0LISDNxvyPLL5vcbjeF8azth1BeRdr61tgGbmvTy9mcnTvqg16a37opkpSqYX3Y0P98/XAxZiUSO1ovnh19xAKFLnrw53zE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=i9QM3M7+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="i9QM3M7+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4774C433F1; Thu, 11 Apr 2024 10:16:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712830581; bh=7LHc9cDRJKpfK4Pb8QXkAZQ8s39wOtwz18WlOgKNOBk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i9QM3M7+WHgzh80X/hzjsej4KbAYAWmDTByeVYelGFww8QI0lDf7vUfiS1S09b79O mWhGbFKRaD0YFLSQNoaHUE8befoyA93WKGIglrsoG9PCeVxxwdWc1b4XSsO4N9Tmbg UZtUrGlu2qD8+kaEbNtvn3Ls5xIbb8ApOqAF3ZVM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alex Lyakas , Josef Bacik , Qu Wenruo , Filipe Manana , David Sterba , Sasha Levin Subject: [PATCH 5.4 048/215] btrfs: fix off-by-one chunk length calculation at contains_pending_extent() Date: Thu, 11 Apr 2024 11:54:17 +0200 Message-ID: <20240411095426.338943379@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240411095424.875421572@linuxfoundation.org> References: <20240411095424.875421572@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Filipe Manana [ Upstream commit ae6bd7f9b46a29af52ebfac25d395757e2031d0d ] At contains_pending_extent() the value of the end offset of a chunk we found in the device's allocation state io tree is inclusive, so when we calculate the length we pass to the in_range() macro, we must sum 1 to the expression "physical_end - physical_offset". In practice the wrong calculation should be harmless as chunks sizes are never 1 byte and we should never have 1 byte ranges of unallocated space. Nevertheless fix the wrong calculation. Reported-by: Alex Lyakas Link: https://lore.kernel.org/linux-btrfs/CAOcd+r30e-f4R-5x-S7sV22RJPe7+pgwherA6xqN2_qe7o4XTg@mail.gmail.com/ Fixes: 1c11b63eff2a ("btrfs: replace pending/pinned chunks lists with io tree") CC: stable@vger.kernel.org # 6.1+ Reviewed-by: Josef Bacik Reviewed-by: Qu Wenruo Signed-off-by: Filipe Manana Signed-off-by: David Sterba Signed-off-by: Sasha Levin --- fs/btrfs/volumes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index e11c8da9a5605..5539e672d70a3 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -1638,7 +1638,7 @@ static bool contains_pending_extent(struct btrfs_device *device, u64 *start, if (in_range(physical_start, *start, len) || in_range(*start, physical_start, - physical_end - physical_start)) { + physical_end + 1 - physical_start)) { *start = physical_end + 1; return true; } -- 2.43.0