From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E6932EAE5; Thu, 11 Apr 2024 10:18:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712830710; cv=none; b=DDEN+X9x9JIEFdNAUqKESB7urQi1pGe6ffHqFRNHoTLbSCJYBnuqjxJ0Gmq9AlkdPCxL+hwFqYy/+QXMu7SWNGVm3UqgXYOJlW4jB/cp/mIeZi+QKydwgqAY0blyaG7G9DsrQVv2fXG19r0m9h6+NCYd2saJTRVFdygy1OqMxzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712830710; c=relaxed/simple; bh=+P4XDqBr9jCLiOK20kTI87dLT6ZTEf/Q6HmO/MHHnnE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aFegiXP8opUXON9TSjDEUDv5L8KuWs5xpqhzujkyx9c1DxTG3flW96OZLNPfKDqXoHk1dwm3gdTCsv5oiyv+J9QuW+8QBbFwMAgq3dNBFDldArKOGqwz/pphgogiq/xbtvQQzikMxdO+mTvmmf77u+x5cnOQ8kfg+nlq7PgurTw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pIrWkMlY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pIrWkMlY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 569B7C433F1; Thu, 11 Apr 2024 10:18:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712830709; bh=+P4XDqBr9jCLiOK20kTI87dLT6ZTEf/Q6HmO/MHHnnE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pIrWkMlYhrM9lmTEdNdThJ3EU5hqn6e2h3qnSF2cSB+3dW1kwSvmF0JjDznim1VhP iAY2VUyHEIzB7uqbCxVM8vcKsWqFGsLQnGU0wLsP4IDU4PtAQqcV2YBNHhoC2e/NJc c9WxHld4yHoSK9xGZlmaDT4lyyoITXfbPUqGZT/g= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Eric Biggers , Benjamin LaHaise , Eric Biggers , Christoph Hellwig , Avi Kivity , Sandeep Dhavale , Jens Axboe , Kent Overstreet , Bart Van Assche , Christian Brauner Subject: [PATCH 5.4 091/215] fs/aio: Check IOCB_AIO_RW before the struct aio_kiocb conversion Date: Thu, 11 Apr 2024 11:55:00 +0200 Message-ID: <20240411095427.638353771@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240411095424.875421572@linuxfoundation.org> References: <20240411095424.875421572@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bart Van Assche commit 961ebd120565cb60cebe21cb634fbc456022db4a upstream. The first kiocb_set_cancel_fn() argument may point at a struct kiocb that is not embedded inside struct aio_kiocb. With the current code, depending on the compiler, the req->ki_ctx read happens either before the IOCB_AIO_RW test or after that test. Move the req->ki_ctx read such that it is guaranteed that the IOCB_AIO_RW test happens first. Reported-by: Eric Biggers Cc: Benjamin LaHaise Cc: Eric Biggers Cc: Christoph Hellwig Cc: Avi Kivity Cc: Sandeep Dhavale Cc: Jens Axboe Cc: Greg Kroah-Hartman Cc: Kent Overstreet Cc: stable@vger.kernel.org Fixes: b820de741ae4 ("fs/aio: Restrict kiocb_set_cancel_fn() to I/O submitted via libaio") Signed-off-by: Bart Van Assche Link: https://lore.kernel.org/r/20240304235715.3790858-1-bvanassche@acm.org Reviewed-by: Jens Axboe Reviewed-by: Eric Biggers Signed-off-by: Christian Brauner Signed-off-by: Greg Kroah-Hartman --- fs/aio.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- a/fs/aio.c +++ b/fs/aio.c @@ -566,8 +566,8 @@ static int aio_setup_ring(struct kioctx void kiocb_set_cancel_fn(struct kiocb *iocb, kiocb_cancel_fn *cancel) { - struct aio_kiocb *req = container_of(iocb, struct aio_kiocb, rw); - struct kioctx *ctx = req->ki_ctx; + struct aio_kiocb *req; + struct kioctx *ctx; unsigned long flags; /* @@ -577,9 +577,13 @@ void kiocb_set_cancel_fn(struct kiocb *i if (!(iocb->ki_flags & IOCB_AIO_RW)) return; + req = container_of(iocb, struct aio_kiocb, rw); + if (WARN_ON_ONCE(!list_empty(&req->ki_list))) return; + ctx = req->ki_ctx; + spin_lock_irqsave(&ctx->ctx_lock, flags); list_add_tail(&req->ki_list, &ctx->active_reqs); req->ki_cancel = cancel;