From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B799145FF0; Thu, 11 Apr 2024 10:20:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712830850; cv=none; b=m32NfZzrZW2ONxbEFBkO5sEaeEJBQs3NR2SMnS9ImuS1vB102/saLFt3vn8sxvNYHqz8JFv8Rp8X2xT0v8be8MdRcxiNdZPrgR+T203232Wc172F7FJO8bi+6owmXaifvzio6vsbtnIEoLicd7OrWLhuMlbsDxT5sjc2WsoBopw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712830850; c=relaxed/simple; bh=lfBH/YOLfitkV8w0fqrLoupTUjuFVfTliaQTQQWAqLw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gVjuk0uEMTSwO25hdefto0K3l77A0A6rBbrXdkUHCtcQAK0puKV8PMfgM38RIJAB+T4t2x+/VvNkV1A9nIskxtplgvy1W0OF64LPOZer87ipZq+y9zF/OWJR0xwENtQO79nzfm0inEsGNCHUNiu7o/yJTAFWABqGBjkEDWjO/DY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JjEvC64S; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JjEvC64S" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2296AC433F1; Thu, 11 Apr 2024 10:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712830850; bh=lfBH/YOLfitkV8w0fqrLoupTUjuFVfTliaQTQQWAqLw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JjEvC64SzSWhGDfeO3YUlVMDAP+9GikzE2J81BXPuSd+f6PejspMqgbXPqKmwZigE Jpi3UUL4R9EWmfqrRMY/mXF7nWfIK7kJYDCwMhlvI8hewez1XX36r1n1pRMNyUTDcB 3yZcdUhPsz+q5rCVuujDIy7m0+h1FwQK+zrNGsKs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mahmoud Adam , Simon Horman , Jakub Kicinski Subject: [PATCH 5.4 138/215] net/rds: fix possible cp null dereference Date: Thu, 11 Apr 2024 11:55:47 +0200 Message-ID: <20240411095429.040975042@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240411095424.875421572@linuxfoundation.org> References: <20240411095424.875421572@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mahmoud Adam commit 62fc3357e079a07a22465b9b6ef71bb6ea75ee4b upstream. cp might be null, calling cp->cp_conn would produce null dereference [Simon Horman adds:] Analysis: * cp is a parameter of __rds_rdma_map and is not reassigned. * The following call-sites pass a NULL cp argument to __rds_rdma_map() - rds_get_mr() - rds_get_mr_for_dest * Prior to the code above, the following assumes that cp may be NULL (which is indicative, but could itself be unnecessary) trans_private = rs->rs_transport->get_mr( sg, nents, rs, &mr->r_key, cp ? cp->cp_conn : NULL, args->vec.addr, args->vec.bytes, need_odp ? ODP_ZEROBASED : ODP_NOT_NEEDED); * The code modified by this patch is guarded by IS_ERR(trans_private), where trans_private is assigned as per the previous point in this analysis. The only implementation of get_mr that I could locate is rds_ib_get_mr() which can return an ERR_PTR if the conn (4th) argument is NULL. * ret is set to PTR_ERR(trans_private). rds_ib_get_mr can return ERR_PTR(-ENODEV) if the conn (4th) argument is NULL. Thus ret may be -ENODEV in which case the code in question will execute. Conclusion: * cp may be NULL at the point where this patch adds a check; this patch does seem to address a possible bug Fixes: c055fc00c07b ("net/rds: fix WARNING in rds_conn_connect_if_down") Cc: stable@vger.kernel.org # v4.19+ Signed-off-by: Mahmoud Adam Reviewed-by: Simon Horman Link: https://lore.kernel.org/r/20240326153132.55580-1-mngyadam@amazon.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/rds/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/rds/rdma.c +++ b/net/rds/rdma.c @@ -280,7 +280,7 @@ static int __rds_rdma_map(struct rds_soc kfree(sg); ret = PTR_ERR(trans_private); /* Trigger connection so that its ready for the next retry */ - if (ret == -ENODEV) + if (ret == -ENODEV && cp) rds_conn_connect_if_down(cp->cp_conn); goto out; }