From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C23B146D51; Thu, 11 Apr 2024 10:23:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712831022; cv=none; b=bvHKMiu7OHms55o15k8jXQn2ubSIwzxDlhelP8blrWI1s2VoDa9X5dFAa15C/dQNt0r366vqd1XYMFlR+C/jEZtn6UhL5naMgx0i6jKw5zXb+tczfBWPtmAr1QZjXFo2gqhjjxctXoK8bMIYibPfTkTt8cyrvCv2JieeAMQL9cc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712831022; c=relaxed/simple; bh=+Q+fg8vXq2XpyQJwNR9uGrcbdz3/OrNhkxXI80xufK0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Hv3Z8Mjn/2iQLtV/HWAUvHISQ8UbCF1WcKvytDwL8X233WULkN2KDKweN669vxwavqAvFN1xE8ow5PkOe5ug2blADubNXsXCguynp4ijn/XNU150HH4iXHkO6ZwZfUComVpw1w7EdcFKVWp5NDmaR0CdGwDDCz2ifMCRdYmnyPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=kRXzuvRr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="kRXzuvRr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 147B1C433C7; Thu, 11 Apr 2024 10:23:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712831022; bh=+Q+fg8vXq2XpyQJwNR9uGrcbdz3/OrNhkxXI80xufK0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kRXzuvRrs6PaMBdmWv7TqXxgXCo6Mdi5/g1QYm6vFMFJEUB1zz00wdSr98lJUttN7 qR4HK0p34qq5eKK8jbCh4wSU8dUvLhHt0ZT5sN8t2H9xfEl0mPiRQUys63bkvBZTlL 5hw1GQG0khdP2TGjulihItT4lJXzkpnDPw6xreC4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Colin Ian King , Sasha Levin Subject: [PATCH 5.4 198/215] usb: sl811-hcd: only defined function checkdone if QUIRK2 is defined Date: Thu, 11 Apr 2024 11:56:47 +0200 Message-ID: <20240411095430.811063581@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240411095424.875421572@linuxfoundation.org> References: <20240411095424.875421572@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Colin Ian King [ Upstream commit 12f371e2b6cb4b79c788f1f073992e115f4ca918 ] Function checkdone is only required if QUIRK2 is defined, so add appropriate #if / #endif around the function. Cleans up clang scan build warning: drivers/usb/host/sl811-hcd.c:588:18: warning: unused function 'checkdone' [-Wunused-function] Signed-off-by: Colin Ian King Link: https://lore.kernel.org/r/20240307111351.1982382-1-colin.i.king@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/host/sl811-hcd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/sl811-hcd.c b/drivers/usb/host/sl811-hcd.c index 936fddc6d8207..3cf8fce40c9dc 100644 --- a/drivers/usb/host/sl811-hcd.c +++ b/drivers/usb/host/sl811-hcd.c @@ -585,6 +585,7 @@ done(struct sl811 *sl811, struct sl811h_ep *ep, u8 bank) finish_request(sl811, ep, urb, urbstat); } +#ifdef QUIRK2 static inline u8 checkdone(struct sl811 *sl811) { u8 ctl; @@ -616,6 +617,7 @@ static inline u8 checkdone(struct sl811 *sl811) #endif return irqstat; } +#endif static irqreturn_t sl811h_irq(struct usb_hcd *hcd) { -- 2.43.0