From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E467140E3D; Thu, 11 Apr 2024 10:24:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712831049; cv=none; b=JVr2ss5sN7rb6sgAAruTcqOVgJQqy0LOqQ4BT60gsJPcKU20iEtugCWtMkqf2EI/eZwQLTtNDLcF5ODnuKidhaQwJ+O/pVGTOuvAB0okJoBtZ65oJZeBHxAa+PZXvQei1r9OLxa3+HGuKzuKPDQDTNSpokvwlrqOmZX9ZtQtrvM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712831049; c=relaxed/simple; bh=KmNJCCdzYah9C+1Pqq1Pl1R9UXXzZLyNiV/xPHEDSSY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j9+SquF6AyjbWnrEuJ9ct3mkZIaeLpyiMbOrPJW0wzkF2kKAWp0S8P5DUpA2rvCdDyW4CNsx6KPj8EGnhoLQMM88guW3BgPyWyVH+BigZUcIlScd03VNIUAIGKAEGxHUqFEXU+BDOLmoOiYvJEcsTv9aG/A0oOr/vNNC+lg31sk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=v/FLf8ow; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="v/FLf8ow" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98741C43390; Thu, 11 Apr 2024 10:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712831049; bh=KmNJCCdzYah9C+1Pqq1Pl1R9UXXzZLyNiV/xPHEDSSY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=v/FLf8owxeCmxfiUNOqPMKufGGtEe4eBFdwtquqxekCzREeCVpRGtj3vtOUzgGgDu RTKUA1LdN2hYmD33Vw/l/gAK0RaFN/DQ1tZt3cnK/sR1hY8+lDXh3unCc0lyvowB6V oejUXYKLN/eq7I4Bj61pQlKemyUIrCyqbTC+hjBM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@kernel.org, "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , David Hildenbrand Subject: [PATCH 5.4 207/215] virtio: reenable config if freezing device failed Date: Thu, 11 Apr 2024 11:56:56 +0200 Message-ID: <20240411095431.075787164@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240411095424.875421572@linuxfoundation.org> References: <20240411095424.875421572@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: David Hildenbrand commit 310227f42882c52356b523e2f4e11690eebcd2ab upstream. Currently, we don't reenable the config if freezing the device failed. For example, virtio-mem currently doesn't support suspend+resume, and trying to freeze the device will always fail. Afterwards, the device will no longer respond to resize requests, because it won't get notified about config changes. Let's fix this by re-enabling the config if freezing fails. Fixes: 22b7050a024d ("virtio: defer config changed notifications") Cc: Cc: "Michael S. Tsirkin" Cc: Jason Wang Cc: Xuan Zhuo Signed-off-by: David Hildenbrand Message-Id: <20240213135425.795001-1-david@redhat.com> Signed-off-by: Michael S. Tsirkin Signed-off-by: Greg Kroah-Hartman --- drivers/virtio/virtio.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -381,13 +381,19 @@ EXPORT_SYMBOL_GPL(unregister_virtio_devi int virtio_device_freeze(struct virtio_device *dev) { struct virtio_driver *drv = drv_to_virtio(dev->dev.driver); + int ret; virtio_config_disable(dev); dev->failed = dev->config->get_status(dev) & VIRTIO_CONFIG_S_FAILED; - if (drv && drv->freeze) - return drv->freeze(dev); + if (drv && drv->freeze) { + ret = drv->freeze(dev); + if (ret) { + virtio_config_enable(dev); + return ret; + } + } return 0; }