From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 843B2146A74; Thu, 11 Apr 2024 10:41:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712832061; cv=none; b=kcVvoR/QGXSQF02cMJzwoymAUZHdv7REy4b5S1tHR3qCY5boW05evvWKjO0tlZmm+peLqLKLUIG1AgfjEu5nUwokx2oa05YmH5zXiNxVCUAtcSIr6OnsZroPyoIpVA6FCJFbK3wsmADnNCCpiAfRo9lMLE67PhoRmf1pmXQZ+58= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712832061; c=relaxed/simple; bh=6rSkMh0Hvx0HfHTlgVmZI/ixH1FiYr4rDhH9IS9+iRM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RLQsR4khhkspAR648tof9rdAxla8jGfeJgoEVoTRy8Dllcox3lpbuiwDk7mcWrRvOrXe89N/41vcRMGahOYdmBKmG+Tz1xFklmZHIio814gv+2zo84NRqMJrqAaI8LT3EJV/RRquDFdZ/tizEmC7uZEpI8XtU3kdT5rMyLEssfA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TjH6ZP9W; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TjH6ZP9W" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09E3BC433C7; Thu, 11 Apr 2024 10:41:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712832061; bh=6rSkMh0Hvx0HfHTlgVmZI/ixH1FiYr4rDhH9IS9+iRM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TjH6ZP9WED9LIqvlf/InF7VpU0s100MYfE4usUNzyyAMClYOA7D/ZgslZkbmn/zr/ tBHQouyVE6zllbZiC9hGGvnM8jTcnqfDJMzNekD91ZTG0B3ObZ17Q8SD6wH4WVKDCR W7AQ03dPybBv3MrZCDZuywMlA35b7lecC1qKHunw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Muhammad Usama Anjum , Jakub Kicinski Subject: [PATCH 5.10 215/294] selftests: reuseaddr_conflict: add missing new line at the end of the output Date: Thu, 11 Apr 2024 11:56:18 +0200 Message-ID: <20240411095442.066421749@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240411095435.633465671@linuxfoundation.org> References: <20240411095435.633465671@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jakub Kicinski commit 31974122cfdeaf56abc18d8ab740d580d9833e90 upstream. The netdev CI runs in a VM and captures serial, so stdout and stderr get combined. Because there's a missing new line in stderr the test ends up corrupting KTAP: # Successok 1 selftests: net: reuseaddr_conflict which should have been: # Success ok 1 selftests: net: reuseaddr_conflict Fixes: 422d8dc6fd3a ("selftest: add a reuseaddr test") Reviewed-by: Muhammad Usama Anjum Link: https://lore.kernel.org/r/20240329160559.249476-1-kuba@kernel.org Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- tools/testing/selftests/net/reuseaddr_conflict.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/tools/testing/selftests/net/reuseaddr_conflict.c +++ b/tools/testing/selftests/net/reuseaddr_conflict.c @@ -109,6 +109,6 @@ int main(void) fd1 = open_port(0, 1); if (fd1 >= 0) error(1, 0, "Was allowed to create an ipv4 reuseport on an already bound non-reuseport socket with no ipv6"); - fprintf(stderr, "Success"); + fprintf(stderr, "Success\n"); return 0; }