From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B455313CF89; Thu, 11 Apr 2024 10:42:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712832171; cv=none; b=O1MZUzyUXsTSy3lYvfymXR9UfPG+M5xilPfvYf/gUBRzPq10U85x4arcUdghpn97tXVEmy547KB2RLhhONKjV5j90V1m6pXY/mzqB06J4jmQYKozOOmc7W9A3SOjc5cWYA1Sz86g6BwFP9hNZEjvYvLIQl0IlaivlC34TDH2QoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712832171; c=relaxed/simple; bh=QMu5gYZwBZomrfGFxAKLuk0wLHWAAuqp5tKo6II3fVs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k3FdIVIsm9c0swP1bbVxal9DxH6rdeGg8Ya4HLSfaUc01ClQeIC+Savhm8vGpTZxLJpOeQ9wPV6h/LuvTJEGK+optEizWAcxceBpvtUY2T6o18sodmlwGchSAagxiM1KcxudFJS9yoSUfjZv4X4YyztbKbD2WvaM4mzwquHERP0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2IYittxt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2IYittxt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39D6BC433F1; Thu, 11 Apr 2024 10:42:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712832171; bh=QMu5gYZwBZomrfGFxAKLuk0wLHWAAuqp5tKo6II3fVs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2IYittxtN2PJkDkljauFm0YRV1s0OotxlJ1/oHo7+d1tyzN/UfiTlshTQ/gvL6CcY n3JJ9t2Z98/DMI6px/JT9MS8fzPvZKtOHUqJ3q3MrcwBBt2uKtftJvGbMg9CvYKwxk G341/9kHEkADkmGW9jcflBhYX53VSmsB9yHGC4Gw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Josef Bacik , Anand Jain , David Sterba , Sasha Levin Subject: [PATCH 5.10 253/294] btrfs: handle chunk tree lookup error in btrfs_relocate_sys_chunks() Date: Thu, 11 Apr 2024 11:56:56 +0200 Message-ID: <20240411095443.183437586@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240411095435.633465671@linuxfoundation.org> References: <20240411095435.633465671@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: David Sterba [ Upstream commit 7411055db5ce64f836aaffd422396af0075fdc99 ] The unhandled case in btrfs_relocate_sys_chunks() loop is a corruption, as it could be caused only by two impossible conditions: - at first the search key is set up to look for a chunk tree item, with offset -1, this is an inexact search and the key->offset will contain the correct offset upon a successful search, a valid chunk tree item cannot have an offset -1 - after first successful search, the found_key corresponds to a chunk item, the offset is decremented by 1 before the next loop, it's impossible to find a chunk item there due to alignment and size constraints Reviewed-by: Josef Bacik Reviewed-by: Anand Jain Signed-off-by: David Sterba Signed-off-by: Sasha Levin --- fs/btrfs/volumes.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 9a05313c69f33..09c23626feba4 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -3178,7 +3178,17 @@ static int btrfs_relocate_sys_chunks(struct btrfs_fs_info *fs_info) mutex_unlock(&fs_info->delete_unused_bgs_mutex); goto error; } - BUG_ON(ret == 0); /* Corruption */ + if (ret == 0) { + /* + * On the first search we would find chunk tree with + * offset -1, which is not possible. On subsequent + * loops this would find an existing item on an invalid + * offset (one less than the previous one, wrong + * alignment and size). + */ + ret = -EUCLEAN; + goto error; + } ret = btrfs_previous_item(chunk_root, path, key.objectid, key.type); -- 2.43.0