From: Greg KH <gregkh@linuxfoundation.org>
To: David Hildenbrand <david@redhat.com>
Cc: stable@vger.kernel.org, stable@kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: Re: [PATCH 6.1.y] virtio: reenable config if freezing device failed
Date: Thu, 11 Apr 2024 09:44:21 +0200 [thread overview]
Message-ID: <2024041112-thrash-unstylish-2cf5@gregkh> (raw)
In-Reply-To: <20240410092758.151321-1-david@redhat.com>
On Wed, Apr 10, 2024 at 11:27:58AM +0200, David Hildenbrand wrote:
> Currently, we don't reenable the config if freezing the device failed.
>
> For example, virtio-mem currently doesn't support suspend+resume, and
> trying to freeze the device will always fail. Afterwards, the device
> will no longer respond to resize requests, because it won't get notified
> about config changes.
>
> Let's fix this by re-enabling the config if freezing fails.
>
> Fixes: 22b7050a024d ("virtio: defer config changed notifications")
> Cc: <stable@kernel.org>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> Message-Id: <20240213135425.795001-1-david@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> (cherry picked from commit 310227f42882c52356b523e2f4e11690eebcd2ab)
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> drivers/virtio/virtio.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
All now queued up,t hanks.
greg k-h
prev parent reply other threads:[~2024-04-11 7:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 12:12 FAILED: Patch "virtio: reenable config if freezing device failed" failed to apply to 6.1-stable tree Sasha Levin
2024-04-10 9:27 ` [PATCH 6.1.y] virtio: reenable config if freezing device failed David Hildenbrand
2024-04-11 7:44 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024041112-thrash-unstylish-2cf5@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=david@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=stable@kernel.org \
--cc=stable@vger.kernel.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox