Re: Patch "Revert "s390/ism: fix receive message buffer allocation"" has been added to the 6.8-stable tree

Re: Patch "Revert "s390/ism: fix receive message buffer allocation"" has been added to the 6.8-stable tree

[Heiko Carstens]

On Mon, Apr 15, 2024 at 04:59:24AM -0400, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
> 
>     Revert "s390/ism: fix receive message buffer allocation"
> 
> to the 6.8-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      revert-s390-ism-fix-receive-message-buffer-allocatio.patch
> and it can be found in the queue-6.8 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
> 
> 
> 
> commit 8568beeed3944bd4bf4c3683993a9df6ae53fbb7
> Author: Gerd Bayer <gbayer@linux.ibm.com>
> Date:   Tue Apr 9 13:37:53 2024 +0200
> 
>     Revert "s390/ism: fix receive message buffer allocation"
>     
>     [ Upstream commit d51dc8dd6ab6f93a894ff8b38d3b8d02c98eb9fb ]
>     
>     This reverts commit 58effa3476536215530c9ec4910ffc981613b413.
>     Review was not finished on this patch. So it's not ready for
>     upstreaming.
>     
>     Signed-off-by: Gerd Bayer <gbayer@linux.ibm.com>
>     Link: https://lore.kernel.org/r/20240409113753.2181368-1-gbayer@linux.ibm.com
>     Fixes: 58effa347653 ("s390/ism: fix receive message buffer allocation")
>     Signed-off-by: Paolo Abeni <pabeni@redhat.com>
>     Signed-off-by: Sasha Levin <sashal@kernel.org>

I'm not sure if it makes sense to add and revert a patch within a
single stable queue (the same applies to 6.6). It might make sense to
drop both patches.

Re: Patch "Revert "s390/ism: fix receive message buffer allocation"" has been added to the 6.8-stable tree

[Greg KH]

On Mon, Apr 15, 2024 at 02:42:16PM +0200, Heiko Carstens wrote:
> On Mon, Apr 15, 2024 at 04:59:24AM -0400, Sasha Levin wrote:
> > This is a note to let you know that I've just added the patch titled
> > 
> >     Revert "s390/ism: fix receive message buffer allocation"
> > 
> > to the 6.8-stable tree which can be found at:
> >     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > 
> > The filename of the patch is:
> >      revert-s390-ism-fix-receive-message-buffer-allocatio.patch
> > and it can be found in the queue-6.8 subdirectory.
> > 
> > If you, or anyone else, feels it should not be added to the stable tree,
> > please let <stable@vger.kernel.org> know about it.
> > 
> > 
> > 
> > commit 8568beeed3944bd4bf4c3683993a9df6ae53fbb7
> > Author: Gerd Bayer <gbayer@linux.ibm.com>
> > Date:   Tue Apr 9 13:37:53 2024 +0200
> > 
> >     Revert "s390/ism: fix receive message buffer allocation"
> >     
> >     [ Upstream commit d51dc8dd6ab6f93a894ff8b38d3b8d02c98eb9fb ]
> >     
> >     This reverts commit 58effa3476536215530c9ec4910ffc981613b413.
> >     Review was not finished on this patch. So it's not ready for
> >     upstreaming.
> >     
> >     Signed-off-by: Gerd Bayer <gbayer@linux.ibm.com>
> >     Link: https://lore.kernel.org/r/20240409113753.2181368-1-gbayer@linux.ibm.com
> >     Fixes: 58effa347653 ("s390/ism: fix receive message buffer allocation")
> >     Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> >     Signed-off-by: Sasha Levin <sashal@kernel.org>
> 
> I'm not sure if it makes sense to add and revert a patch within a
> single stable queue (the same applies to 6.6). It might make sense to
> drop both patches.

It makes it easier for us to track that this was applied, otherwise our
scripts get confused and keeps trying to add it back :)

thanks,

greg k-h