From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9F371E501; Mon, 15 Apr 2024 14:43:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713192202; cv=none; b=g9TDk11dtsh80LA4RApaT5lpz7wLkR/iAmG/cYlPQLGA/X3R8op5yurgJTFXgbxl4nODM0mYm6wfCIiVMe+feiYoe4eDvT6Z84tCsXML5Vq2wY6/6vU5v2e3d+89x3KBMMjKMo2RPiaW8nsXeX4mzH5cgqTs6qjVyUe7YRkbB1o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713192202; c=relaxed/simple; bh=6cS9xaLap0THNn+I6r41lyfxsl5v1ExZqXceRROdclc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=D93RxBaUieCEBNjCAiu3FDl0v1RAIY7hknXUniqCBPgcLvnMcv6UM2cNtXvPxNGdT8nySwNFpx/M3xqa2jVFUSxOervNw3q62lw1w4umrBYgrvfchP88+X0CnbkcYwYAQiH1GxDOQ1oOGS3carGnVxsTuRKXPtR+3YHgJXAK9ms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=inO63tX9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="inO63tX9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3056BC113CC; Mon, 15 Apr 2024 14:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1713192202; bh=6cS9xaLap0THNn+I6r41lyfxsl5v1ExZqXceRROdclc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=inO63tX9TMmJNjLBgxYHRcWU7UB8Bh/vEP3j8lNBLAf4lK6U8Bjun5Vcv/EQiwDNs JfkMsUFnteRUZ+neAdmgacmD5FIsevE6XlsIVituoCkriYV+XbOf8KC48iKFYHrBL8 szaLdFWE/ePWJkaAn+kkmyj9FHDzHATw/LVrqpCI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Dmitry Baryshkov , Jani Nikula , Thomas Zimmermann Subject: [PATCH 5.15 30/45] drm/client: Fully protect modes[] with dev->mode_config.mutex Date: Mon, 15 Apr 2024 16:21:37 +0200 Message-ID: <20240415141943.148333129@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240415141942.235939111@linuxfoundation.org> References: <20240415141942.235939111@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ville Syrjälä commit 3eadd887dbac1df8f25f701e5d404d1b90fd0fea upstream. The modes[] array contains pointers to modes on the connectors' mode lists, which are protected by dev->mode_config.mutex. Thus we need to extend modes[] the same protection or by the time we use it the elements may already be pointing to freed/reused memory. Cc: stable@vger.kernel.org Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/10583 Signed-off-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20240404203336.10454-2-ville.syrjala@linux.intel.com Reviewed-by: Dmitry Baryshkov Reviewed-by: Jani Nikula Reviewed-by: Thomas Zimmermann Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/drm_client_modeset.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/drm_client_modeset.c +++ b/drivers/gpu/drm/drm_client_modeset.c @@ -775,6 +775,7 @@ int drm_client_modeset_probe(struct drm_ unsigned int total_modes_count = 0; struct drm_client_offset *offsets; unsigned int connector_count = 0; + /* points to modes protected by mode_config.mutex */ struct drm_display_mode **modes; struct drm_crtc **crtcs; int i, ret = 0; @@ -843,7 +844,6 @@ int drm_client_modeset_probe(struct drm_ drm_client_pick_crtcs(client, connectors, connector_count, crtcs, modes, 0, width, height); } - mutex_unlock(&dev->mode_config.mutex); drm_client_modeset_release(client); @@ -873,6 +873,7 @@ int drm_client_modeset_probe(struct drm_ modeset->y = offset->y; } } + mutex_unlock(&dev->mode_config.mutex); mutex_unlock(&client->modeset_mutex); out: