From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F2687581F; Mon, 15 Apr 2024 14:32:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713191569; cv=none; b=lgJvf7CdFp1CwCX0lsBL7jvGCJ+PIeLzDpV67laJ47DG7QbliY06Qplorp56BNaLcH6gMDoTRXhl3T8ZmP2tID+nGZ4NRnJpumUpwPLfJDXK0urTLkC44gwgf2nVTLt6jkc9utVLmorqJGWyWMARNiK+hwdpyC/fSo4pZQ1JOWY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713191569; c=relaxed/simple; bh=mZf/B91FzxATR2bO7l9S9TvgmuDYQNl4gE/5G8DdnLM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aE7/dMseua5nnenkyOMA3uIvkqgAYEY3mnFI4XAqiqvKzaD9o+zo6L6PklzHL9VAGxdvcDa9EgMIHA93vqJqrHr3PVAw7H0Rlt+l3HUwLjOw7VoVtlr8pJbWD8MDuvUcgsivz/xbTBGamFJEySX0nk1XMaEGy9vUxm6MTvHoOkk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VPFYcWp+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VPFYcWp+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C8A2C2BD10; Mon, 15 Apr 2024 14:32:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1713191569; bh=mZf/B91FzxATR2bO7l9S9TvgmuDYQNl4gE/5G8DdnLM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VPFYcWp+870Qxde4KPWEqI9Z2Zf2qaKc6XHOwj1fdym11UcDyiB/7QCLGMxAY4VU3 BEIY0MN0iNL3WGDac6j2I1Puf1zjR1U+SE4ptM3l6wWOwdV7/yUmVn8eeGnLpuDlv4 hG4dSTM/j3rI3iPBG94Xn5PYj/5i4Ba/wzzSHVX0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nini Song , Hans Verkuil Subject: [PATCH 6.6 014/122] media: cec: core: remove length check of Timer Status Date: Mon, 15 Apr 2024 16:19:39 +0200 Message-ID: <20240415141953.806109213@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240415141953.365222063@linuxfoundation.org> References: <20240415141953.365222063@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nini Song commit ce5d241c3ad4568c12842168288993234345c0eb upstream. The valid_la is used to check the length requirements, including special cases of Timer Status. If the length is shorter than 5, that means no Duration Available is returned, the message will be forced to be invalid. However, the description of Duration Available in the spec is that this parameter may be returned when these cases, or that it can be optionally return when these cases. The key words in the spec description are flexible choices. Remove the special length check of Timer Status to fit the spec which is not compulsory about that. Signed-off-by: Nini Song Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/cec/core/cec-adap.c | 14 -------------- 1 file changed, 14 deletions(-) --- a/drivers/media/cec/core/cec-adap.c +++ b/drivers/media/cec/core/cec-adap.c @@ -1124,20 +1124,6 @@ void cec_received_msg_ts(struct cec_adap if (valid_la && min_len) { /* These messages have special length requirements */ switch (cmd) { - case CEC_MSG_TIMER_STATUS: - if (msg->msg[2] & 0x10) { - switch (msg->msg[2] & 0xf) { - case CEC_OP_PROG_INFO_NOT_ENOUGH_SPACE: - case CEC_OP_PROG_INFO_MIGHT_NOT_BE_ENOUGH_SPACE: - if (msg->len < 5) - valid_la = false; - break; - } - } else if ((msg->msg[2] & 0xf) == CEC_OP_PROG_ERROR_DUPLICATE) { - if (msg->len < 5) - valid_la = false; - } - break; case CEC_MSG_RECORD_ON: switch (msg->msg[2]) { case CEC_OP_RECORD_SRC_OWN: