From: Greg KH <gregkh@linuxfoundation.org>
To: George Guo <dongtai.guo@linux.dev>
Cc: tom.zanussi@linux.intel.com, stable@vger.kernel.org,
Tom Zanussi <tzanussi@gmail.com>,
Namhyung Kim <namhyung@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 4.19.y v4 2/2] tracing: Use var_refs[] for hist trigger reference checking
Date: Mon, 15 Apr 2024 13:17:29 +0200 [thread overview]
Message-ID: <2024041518-lunchroom-anemic-a740@gregkh> (raw)
In-Reply-To: <20240412093041.2334396-3-dongtai.guo@linux.dev>
On Fri, Apr 12, 2024 at 05:30:41PM +0800, George Guo wrote:
> From: Tom Zanussi <tzanussi@gmail.com>
>
> commit e4f6d245031e04bdd12db390298acec0474a1a46 upstream.
>
> Since all the variable reference hist_fields are collected into
> hist_data->var_refs[] array, there's no need to go through all the
> fields looking for them, or in separate arrays like synth_var_refs[],
> which will be going away soon anyway.
>
> This also allows us to get rid of some unnecessary code and functions
> currently used for the same purpose.
>
> Link: http://lkml.kernel.org/r/1545246556.4239.7.camel@gmail.com
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>
> Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> ---
> kernel/trace/trace_events_hist.c | 68 ++++++--------------------------
> 1 file changed, 11 insertions(+), 57 deletions(-)
Again, you also need to sign off on this.
thanks,
greg k-h
prev parent reply other threads:[~2024-04-15 11:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 9:30 [PATCH 4.19.y v4 0/2] Double-free bug discovery on testing trigger-field-variable-support.tc George Guo
2024-04-12 9:30 ` [PATCH 4.19.y v4 1/2] tracing: Remove hist trigger synth_var_refs George Guo
2024-04-15 11:17 ` Greg KH
2024-04-12 9:30 ` [PATCH 4.19.y v4 2/2] tracing: Use var_refs[] for hist trigger reference checking George Guo
2024-04-15 11:17 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024041518-lunchroom-anemic-a740@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dongtai.guo@linux.dev \
--cc=mhiramat@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=tom.zanussi@linux.intel.com \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox