From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 383D46A333; Wed, 17 Apr 2024 07:05:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713337517; cv=none; b=oEOQQoGJ6BAv3IfLMzEuyzohFRnGxgBaBnFvXQw6nPmo/GKPoxZbhlmQPh4Ee3RgpbklydBFPl1D5pgHLRka5Cld9LOEtNanWWe8xdQdV2Ic8V/VZnq4AKxHfk2+RX3SF+MBuR4H4FNTEyQoTCePX2Y3oMy2CJxYgTaWeW0feV0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713337517; c=relaxed/simple; bh=LoRwP/hEcMXMPwH3S6gBEGGdVfFRMPJvfpf8Ayzlb9c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H4qovhoD3vEEwikZg09owSnjeNo4rNfLTjyJasIzCzoGydceBov3lzg+tECq6RaADr8Z7rQutpbPyaqP+T/SefZo9IG3lUOU+C2bYN69zANHrs+EPYhHQcRATuV93mhAqiS3kiV9n3EHkOuklSrUgruYmYoJoy4A/XCV9bMZ18Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dF+7OSQT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dF+7OSQT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26288C072AA; Wed, 17 Apr 2024 07:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1713337516; bh=LoRwP/hEcMXMPwH3S6gBEGGdVfFRMPJvfpf8Ayzlb9c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dF+7OSQTs5upJAfE8SIMKVG3CNOVNuv97qRVM64REg3xFdjCUGvVuf1UrbgZjJy5y TsMHZULLXaw2bBeBKp7IHpHU6YuGbB/AKmC4Dik5MjGh9MyPcifydtsFxiVo+jc1wo nUJTczy1nxh+spSvDJmjP/mYn3fjrhULn1TdJEqU= Date: Wed, 17 Apr 2024 09:05:12 +0200 From: Greg Kroah-Hartman To: Catalin Marinas Cc: Marc Zyngier , Naresh Kamboju , Mark Brown , stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de, conor@kernel.org, allen.lkml@gmail.com, Yihuang Yu , Gavin Shan , Ryan Roberts , Anshuman Khandual , Shaoqin Huang , Will Deacon , linux-arm-kernel@lists.infradead.org, Anders Roxell Subject: Re: [PATCH 6.6 000/122] 6.6.28-rc1 review Message-ID: <2024041744-pretender-clutter-7d4d@gregkh> References: <20240415141953.365222063@linuxfoundation.org> <86y19dqw74.wl-maz@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Apr 16, 2024 at 06:28:10PM +0100, Catalin Marinas wrote: > On Tue, Apr 16, 2024 at 02:22:07PM +0100, Marc Zyngier wrote: > > On Tue, 16 Apr 2024 14:07:30 +0100, > > Naresh Kamboju wrote: > > > On Tue, 16 Apr 2024 at 16:04, Mark Brown wrote: > > > > On Mon, Apr 15, 2024 at 04:19:25PM +0200, Greg Kroah-Hartman wrote: > > > > > This is the start of the stable review cycle for the 6.6.28 release. > > > > > There are 122 patches in this series, all will be posted as a response > > > > > to this one. If anyone has any issues with these being applied, please > > > > > let me know. > > > > > > > > The bisect of the boot issue that's affecting the FVP in v6.6 (only) > > > > landed on c9ad150ed8dd988 (arm64: tlb: Fix TLBI RANGE operand), > > > > e3ba51ab24fdd in mainline, as being the first bad commit - it's also in > > > > the -rc for v6.8 but that seems fine. I've done no investigation beyond > > > > the bisect and looking at the commit log to pull out people to CC and > > > > note that the fix was explicitly targeted at v6.6. > > > > > > Anders investigated this reported issues and bisected and also found > > > the missing commit for stable-rc 6.6 is > > > e2768b798a19 ("arm64/mm: Modify range-based tlbi to decrement scale") > > > > Which is definitely *not* stable candidate. We need to understand why > > the invalidation goes south when the scale go up instead of down. > > If you backport e3ba51ab24fd ("arm64: tlb: Fix TLBI RANGE operand") > which fixes 117940aa6e5f ("KVM: arm64: Define > kvm_tlb_flush_vmid_range()") but without the newer e2768b798a19 > ("arm64/mm: Modify range-based tlbi to decrement scale"), it looks like > "scale" in __flush_tlb_range_op() goes out of range to 4. Tested on my > CBMC model, not on the actual kernel. It may be worth adding some > WARN_ONs in __flush_tlb_range_op() if scale is outside the 0..3 range or > num greater than 31. > > I haven't investigated properly (and I'm off tomorrow, back on Thu) but > it's likely the original code was not very friendly to the maximum > range, never tested. Anyway, if one figures out why it goes out of > range, I think the solution is to also backport e2768b798a19 to stable. How about I drop the offending commit from stable and let you all figure out what needs to be added before applying anything else :) thanks, greg k-h