From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 745F6205E2C; Sun, 21 Apr 2024 06:39:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713681567; cv=none; b=d4MpIa3R2ytwtKOVfb3mva8RUR/eAmGDdrRzty3bs317t5/LZC3vUgswwR/9nm63/+4XPif0ye2uY7hj/GzaE0chMOsOr2WwCeobVaJWB3bV9pDl+byV8/EKxp7Uv8wXMu+prAVXE0PZM94bMixYJRtofZof+/vwOH9pemN/8ho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713681567; c=relaxed/simple; bh=LiRB9rjFKxbX5IKYehMMYf2woCtRaCUAx0H9EFjhyJg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=E/yyYRxMpn3CurtqUPcaKBqYdNi8Bc7dbfuut/6dTiirdI+b4Aic5/tFt1QvqkqIu1nzseCfoFzEYarewz+DrPpdeS9FzNQKNIrOhcVoRd5ABWq8XUKdrekjnaIzBXlcibQiq18EvwZHkNN+ASAJO4FSGl4ja6gGn1bAHLuiQrM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=PKuCF6AT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="PKuCF6AT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 321A7C113CE; Sun, 21 Apr 2024 06:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1713681566; bh=LiRB9rjFKxbX5IKYehMMYf2woCtRaCUAx0H9EFjhyJg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PKuCF6ATamV7RPkPHWQnV/DYYpHVEonNUu1jA8+AbrwodQI+y73xqt8SEeYRPx8jw +VRPflWsy/YTSP6STp+izb0ZJVwpOGthseuF3Bzz68S3N5rKFOSF/SKuijjdfwnwuC pHVLyfDacrxG8nXoXxmndUuX7SgNnv74kgD0gZKI= Date: Sun, 21 Apr 2024 08:39:23 +0200 From: Greg Kroah-Hartman To: Carlos Llamas Cc: Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Suren Baghdasaryan , Serban Constantinescu , linux-kernel@vger.kernel.org, kernel-team@android.com, Alice Ryhl , stable@vger.kernel.org Subject: Re: [PATCH 4/4] binder: fix max_thread type inconsistency Message-ID: <2024042112-landscape-gains-1bb0@gregkh> References: <20240417191418.1341988-1-cmllamas@google.com> <20240417191418.1341988-5-cmllamas@google.com> <2024041858-unwoven-craziness-13a6@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sun, Apr 21, 2024 at 12:00:30AM +0000, Carlos Llamas wrote: > On Thu, Apr 18, 2024 at 06:40:52AM +0200, Greg Kroah-Hartman wrote: > > On Wed, Apr 17, 2024 at 07:13:44PM +0000, Carlos Llamas wrote: > > > The type defined for the BINDER_SET_MAX_THREADS ioctl was changed from > > > size_t to __u32 in order to avoid incompatibility issues between 32 and > > > 64-bit kernels. However, the internal types used to copy from user and > > > store the value were never updated. Use u32 to fix the inconsistency. > > > > > > Fixes: a9350fc859ae ("staging: android: binder: fix BINDER_SET_MAX_THREADS declaration") > > > Reported-by: Arve Hjønnevåg > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Carlos Llamas > > > --- > > > drivers/android/binder.c | 2 +- > > > drivers/android/binder_internal.h | 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > Why does only patch 4/4 need to go into the tree now, and as a stable > > backport, but the first 3 do not? Shouldn't this be two different > > series of patches, one 3 long, and one 1 long, to go to the different > > branches (next and linus)? > > Yes, that is correct. Only patch 4/4 would need to be picked for linus > now and for stable. The others would go to next. Sorry, I was not aware > that sending them separately would be preferred. > > I'll drop 4/4 patch from the series in v2. Let me know if you still need > me to send it again separately. Please do, thanks! greg k-h