From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BF0125779 for ; Sun, 21 Apr 2024 17:44:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713721469; cv=none; b=YDoze7M1M606FSfeUHoTdqu2RwxK8WUxIY7jZgsayWIeqYW1Xa/pU4YRatZz56V0QdcwUq3J+g0u3rPChbiRVhiEZ/ns5XgpxuGPkDbuyGhgxxLSpf+h/HNB1VDYmTYVI352htr3ld0HUaqJKw1x50lv2EIgj1a553+cqJ/eoBM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713721469; c=relaxed/simple; bh=Rxo/QLb3D3FLuHpq7mRBclfypka9nF4CKeJoBwNdfpM=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=SrfcuPmR6HTuGfF07Ed/+nAtkvW+J2ku7PtDqliYrLDXjyWiUmCRKtMaMQMpgFFPwNLruWBEW9lsTuucR4FleBvGjGcU5qfgD2mzXm6Vkz//4l8DAugeT5b0Cv9Exr4SDhjOPAig+qoQqaBpOA0nD0Fi+77omz4WAsTqVyDhe6Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--cmllamas.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=BIHPYHY1; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--cmllamas.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BIHPYHY1" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-61890f3180aso82457317b3.2 for ; Sun, 21 Apr 2024 10:44:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713721467; x=1714326267; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id :mime-version:date:from:to:cc:subject:date:message-id:reply-to; bh=pfJhufGPprljhvqok4xuEp55QbKVyiGYgMx3ut44Am8=; b=BIHPYHY1h0UTofabFuCg7ujlFTprNGseIERqlJkBWKp37GHfi+nziSy+eIluIW4eMP IUeXHLiDQWn8rwu6ShQx6mn/QgaR9JMilJkreXsquyIGw2Nv9Cz9ft4QlG2CtWQJxzwc 1EpOp+MiWiiR7EjDC2a1FkP/kZZFFEWwMHPXl0Rq/4FqxSOi8UpGGBIugiH2HJiFgcol uUoTsaQXHYMnZbb8p9Yotxduo6SGLkXtVZt6tUyZThq7QfH04rH4S9SGwdcUQfxiEDVs SRrxvNiKNO4lU3epXrxuvk2CBpl9FL62PRBsp62hSejRXdgyQDGTeyqqVtl8EtH60yFW Yttg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713721467; x=1714326267; h=content-transfer-encoding:cc:to:from:subject:message-id :mime-version:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pfJhufGPprljhvqok4xuEp55QbKVyiGYgMx3ut44Am8=; b=AWO91Ly/OcE+njVCSXN3EKrgtdqzK77FisVY4YV4Z4gDby4N+wP7uJYSLho0wKgE62 UGD8RoPN+jMkNujYjEhwFSbACaaUCj8rBWQw19JY8Q+6WPNbKefzf5W71ncj3HdQRDG6 p6CrrN2bq75gPnenA7HBtjDZdM0epM+E/r9X3dPfVTeJacVjo4SXDDjV9p84UZsS83Gt kKJagJt2RzW0/7q4dwQeDYFFVJGFq3iijYMMh5RCZ3v2VOeDsO+ttY1Ol9RkZyNKEGAA H4mWnkjYuH1WSMqQSxjpeE1026pRVYbmmSC3kMIMYe87mqkUNuHychkCc44n4DzNlrDM wGjg== X-Forwarded-Encrypted: i=1; AJvYcCUrwkVd++dk4tjvtbBI8EhadIWHHrVZxK9hVZ4BLZtIuQS6yGsphnREuwMDrcJ1Cr6ao7oew6tfoRf6MpPmBmpJkj+Ib1CG X-Gm-Message-State: AOJu0YxjE/X1Pb8HPKvhH2nUC1Nw4lUDfYJGa6306AJzFCVLATikRRwX FL3X+jyXrRWWGJT6ExO1embO3w0bDhWhpWo+R7AT+2oARRawEQK6TWAY7OC37LMX1QGz83mXzHD uW0+KUBEgCg== X-Google-Smtp-Source: AGHT+IFea26EdgRBiy2bok1wSSeQVXwViDdWSFDukZLbc7EAjnnR+53AfvJcxXye0zeBN8dajLnwzb+FJYxlLQ== X-Received: from xllamas.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5070]) (user=cmllamas job=sendgmr) by 2002:a0d:d8cb:0:b0:61a:bfc8:64ce with SMTP id a194-20020a0dd8cb000000b0061abfc864cemr2032717ywe.8.1713721467059; Sun, 21 Apr 2024 10:44:27 -0700 (PDT) Date: Sun, 21 Apr 2024 17:37:49 +0000 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.44.0.769.g3c40516874-goog Message-ID: <20240421173750.3117808-1-cmllamas@google.com> Subject: [PATCH v2] binder: fix max_thread type inconsistency From: Carlos Llamas To: Greg Kroah-Hartman , "=?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?=" , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan , Serban Constantinescu Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable The type defined for the BINDER_SET_MAX_THREADS ioctl was changed from size_t to __u32 in order to avoid incompatibility issues between 32 and 64-bit kernels. However, the internal types used to copy from user and store the value were never updated. Use u32 to fix the inconsistency. Fixes: a9350fc859ae ("staging: android: binder: fix BINDER_SET_MAX_THREADS = declaration") Reported-by: Arve Hj=C3=B8nnev=C3=A5g Cc: Signed-off-by: Carlos Llamas --- Notes: v2: rebased, send fix patch separately per Greg's feedback. drivers/android/binder.c | 2 +- drivers/android/binder_internal.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/android/binder.c b/drivers/android/binder.c index bad28cf42010..5834e829f391 100644 --- a/drivers/android/binder.c +++ b/drivers/android/binder.c @@ -5365,7 +5365,7 @@ static long binder_ioctl(struct file *filp, unsigned = int cmd, unsigned long arg) goto err; break; case BINDER_SET_MAX_THREADS: { - int max_threads; + u32 max_threads; =20 if (copy_from_user(&max_threads, ubuf, sizeof(max_threads))) { diff --git a/drivers/android/binder_internal.h b/drivers/android/binder_int= ernal.h index 7270d4d22207..5b7c80b99ae8 100644 --- a/drivers/android/binder_internal.h +++ b/drivers/android/binder_internal.h @@ -421,7 +421,7 @@ struct binder_proc { struct list_head todo; struct binder_stats stats; struct list_head delivered_death; - int max_threads; + u32 max_threads; int requested_threads; int requested_threads_started; int tmp_ref; --=20 2.44.0.769.g3c40516874-goog