public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH AUTOSEL 6.1 1/9] fs/9p: only translate RWX permissions for plain 9P2000
@ 2024-04-23 11:02 Sasha Levin
  2024-04-23 11:02 ` [PATCH AUTOSEL 6.1 2/9] fs/9p: translate O_TRUNC into OTRUNC Sasha Levin
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: Sasha Levin @ 2024-04-23 11:02 UTC (permalink / raw)
  To: linux-kernel, stable
  Cc: Joakim Sindholt, Eric Van Hensbergen, Sasha Levin, lucho,
	asmadeus, v9fs

From: Joakim Sindholt <opensource@zhasha.com>

[ Upstream commit cd25e15e57e68a6b18dc9323047fe9c68b99290b ]

Garbage in plain 9P2000's perm bits is allowed through, which causes it
to be able to set (among others) the suid bit. This was presumably not
the intent since the unix extended bits are handled explicitly and
conditionally on .u.

Signed-off-by: Joakim Sindholt <opensource@zhasha.com>
Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 fs/9p/vfs_inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
index 5e2657c1dbbe6..a0c5a372dcf62 100644
--- a/fs/9p/vfs_inode.c
+++ b/fs/9p/vfs_inode.c
@@ -85,7 +85,7 @@ static int p9mode2perm(struct v9fs_session_info *v9ses,
 	int res;
 	int mode = stat->mode;
 
-	res = mode & S_IALLUGO;
+	res = mode & 0777; /* S_IRWXUGO */
 	if (v9fs_proto_dotu(v9ses)) {
 		if ((mode & P9_DMSETUID) == P9_DMSETUID)
 			res |= S_ISUID;
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-04-23 11:41 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-23 11:02 [PATCH AUTOSEL 6.1 1/9] fs/9p: only translate RWX permissions for plain 9P2000 Sasha Levin
2024-04-23 11:02 ` [PATCH AUTOSEL 6.1 2/9] fs/9p: translate O_TRUNC into OTRUNC Sasha Levin
2024-04-23 11:02 ` [PATCH AUTOSEL 6.1 3/9] 9p: explicitly deny setlease attempts Sasha Levin
2024-04-23 11:02 ` [PATCH AUTOSEL 6.1 4/9] gpio: wcove: Use -ENOTSUPP consistently Sasha Levin
2024-04-23 11:02 ` [PATCH AUTOSEL 6.1 5/9] gpio: crystalcove: " Sasha Levin
2024-04-23 11:02 ` [PATCH AUTOSEL 6.1 6/9] clk: Don't hold prepare_lock when calling kref_put() Sasha Levin
2024-04-23 11:02 ` [PATCH AUTOSEL 6.1 7/9] fs/9p: drop inodes immediately on non-.L too Sasha Levin
2024-04-23 11:02 ` [PATCH AUTOSEL 6.1 8/9] drm/nouveau/dp: Don't probe eDP ports twice harder Sasha Levin
2024-04-23 11:02 ` [PATCH AUTOSEL 6.1 9/9] net:usb:qmi_wwan: support Rolling modules Sasha Levin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox