[PATCH 6.8 116/158] Revert "mei: vsc: Call wake_up() in the threaded IRQ handler"

Greg Kroah-Hartman
2024-04-23T21:42:26Z

From: Sakari Ailus <sakari.ailus@linux.intel.com>

commit e3dc66d998d2b0c2734db9ca1d6c94c97349529a upstream.

This reverts commit 058a38acba15fd8e7b262ec6e17c4204cb15f984.

It's not necessary to avoid a spinlock, a sleeping lock on PREEMPT_RT, in
an interrupt handler as the interrupt handler itself would be called in a
process context if PREEMPT_RT is enabled. So revert the patch.

Cc: stable@vger.kernel.org # for 6.8
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Tomas Winkler <tomas.winkler@intel.com>
Link: https://lore.kernel.org/r/20240403051341.3534650-1-wentong.wu@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/misc/mei/vsc-tp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/misc/mei/vsc-tp.c
+++ b/drivers/misc/mei/vsc-tp.c
@@ -419,6 +419,8 @@ static irqreturn_t vsc_tp_isr(int irq, v

atomic_inc(&tp->assert_cnt);

+ wake_up(&tp->xfer_wait);
+
return IRQ_WAKE_THREAD;
}

@@ -426,8 +428,6 @@ static irqreturn_t vsc_tp_thread_isr(int
{
struct vsc_tp *tp = data;

- wake_up(&tp->xfer_wait);
-
if (tp->event_notify)
tp->event_notify(tp->event_notify_context);