stable-rc: 5.10: arm: u64_stats_sync.h:136:2: error: implicit declaration of function 'preempt_disable_nested'

stable-rc: 5.10: arm: u64_stats_sync.h:136:2: error: implicit declaration of function 'preempt_disable_nested'

[Naresh Kamboju]

The arm and i386 builds failed with clang-17 and gcc-12 on stable-rc
linux.5.10.y
branch with linked config [1].

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

In file included from init/do_mounts.c:7:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:28:
In file included from include/linux/cgroup-defs.h:20:
include/linux/u64_stats_sync.h:136:2: error: implicit declaration of
function 'preempt_disable_nested'
[-Werror,-Wimplicit-function-declaration]
  136 |         preempt_disable_nested();
      |         ^
include/linux/u64_stats_sync.h:143:2: error: implicit declaration of
function 'preempt_enable_nested'
[-Werror,-Wimplicit-function-declaration]
  143 |         preempt_enable_nested();
      |         ^

Suspecting patch:
 u64_stats: fix u64_stats_init() for lockdep when used repeatedly in one file

    [ Upstream commit 38a15d0a50e0a43778561a5861403851f0b0194c ]

Steps to reproduce:
---
# tuxmake --runtime podman --target-arch arm --toolchain clang-17
--kconfig https://storage.tuxsuite.com/public/linaro/lkft/builds/2f8pIb4fiJ5NY0zeALMmUnqnaa2/config
LLVM=1 LLVM_IAS=0 dtbs dtbs-legacy headers kernel kselftest modules

Links:
 - [1] https://storage.tuxsuite.com/public/linaro/lkft/builds/2f8pIb4fiJ5NY0zeALMmUnqnaa2/config
 - https://storage.tuxsuite.com/public/linaro/lkft/builds/2f8pIb4fiJ5NY0zeALMmUnqnaa2/
 - https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.215-32-gd3c603576d90/testrun/23479825/suite/build/test/clang-17-lkftconfig-no-kselftest-frag/details/

--
Linaro LKFT
https://lkft.linaro.org

Re: stable-rc: 5.10: arm: u64_stats_sync.h:136:2: error: implicit declaration of function 'preempt_disable_nested'

[Greg Kroah-Hartman]

On Tue, Apr 23, 2024 at 01:35:28PM +0530, Naresh Kamboju wrote:
> The arm and i386 builds failed with clang-17 and gcc-12 on stable-rc
> linux.5.10.y
> branch with linked config [1].
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
> In file included from init/do_mounts.c:7:
> In file included from include/linux/suspend.h:5:
> In file included from include/linux/swap.h:9:
> In file included from include/linux/memcontrol.h:13:
> In file included from include/linux/cgroup.h:28:
> In file included from include/linux/cgroup-defs.h:20:
> include/linux/u64_stats_sync.h:136:2: error: implicit declaration of
> function 'preempt_disable_nested'
> [-Werror,-Wimplicit-function-declaration]
>   136 |         preempt_disable_nested();
>       |         ^

That function is not in the queue at all, are you sure you are up to
date?

thanks,

greg k-h

Re: stable-rc: 5.10: arm: u64_stats_sync.h:136:2: error: implicit declaration of function 'preempt_disable_nested'

[Shreeya Patel]

On Tuesday, April 23, 2024 21:52 IST, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Tue, Apr 23, 2024 at 01:35:28PM +0530, Naresh Kamboju wrote:
> > The arm and i386 builds failed with clang-17 and gcc-12 on stable-rc
> > linux.5.10.y
> > branch with linked config [1].
> > 
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > 
> > In file included from init/do_mounts.c:7:
> > In file included from include/linux/suspend.h:5:
> > In file included from include/linux/swap.h:9:
> > In file included from include/linux/memcontrol.h:13:
> > In file included from include/linux/cgroup.h:28:
> > In file included from include/linux/cgroup-defs.h:20:
> > include/linux/u64_stats_sync.h:136:2: error: implicit declaration of
> > function 'preempt_disable_nested'
> > [-Werror,-Wimplicit-function-declaration]
> >   136 |         preempt_disable_nested();
> >       |         ^
> 
> That function is not in the queue at all, are you sure you are up to
> date?
> 

Hi Greg,

Just to add, KernelCI has also reported these failures on stable-rc 5.10 kernel recently.
Following are the details for it :-

32r2el_defconfig ‐ mips ‐ gcc-101 warning — 2 errors
allnoconfig ‐ i386 ‐ gcc-101 warning — 2 errors
haps_hs_smp_defconfig ‐ arc ‐ gcc-107 warnings — 14 errors
i386_defconfig ‐ i386 ‐ gcc-101 warning — 2 errors
imx_v6_v7_defconfig ‐ arm ‐ gcc-107 warnings — 14 errors
multi_v5_defconfig ‐ arm ‐ gcc-108 warnings — 16 errors
multi_v7_defconfig ‐ arm ‐ gcc-107 warnings — 14 errors
omap2plus_defconfig ‐ arm ‐ gcc-108 warnings — 16 errors
rv32_defconfig ‐ riscv ‐ gcc-1010 warnings — 16 errors
tinyconfig ‐ i386 ‐ gcc-101 warning — 2 errors
vexpress_defconfig ‐ arm ‐ gcc-109 warnings — 18 errors

Build Logs Summary
Errors Summary
include/linux/u64_stats_sync.h:143:2: error: implicit declaration of function ‘preempt_enable_nested’; did you mean ‘preempt_enable_no_resched’? [-Werror=implicit-function-declaration]
include/linux/u64_stats_sync.h:136:2: error: implicit declaration of function ‘preempt_disable_nested’; did you mean ‘preempt_disable_notrace’? [-Werror=implicit-function-declaration]
include/linux/u64_stats_sync.h:143:2: error: implicit declaration of function 'preempt_enable_nested'; did you mean 'preempt_enable_no_resched'? [-Werror=implicit-function-declaration]
include/linux/u64_stats_sync.h:136:2: error: implicit declaration of function 'preempt_disable_nested'; did you mean 'preempt_disable_notrace'? [-Werror=implicit-function-declaration]

Warnings Summary
cc1: some warnings being treated as errors
<stdin>:830:2: warning: #warning syscall fstat64 not implemented [-Wcpp]
<stdin>:1127:2: warning: #warning syscall fstatat64 not implemented [-Wcpp]

Detailed information can be found on the KernelCI dashboard :- https://linux.kernelci.org/build/stable-rc/branch/linux-5.10.y/kernel/v5.10.215-32-gd3c603576d90b/

Thanks,
Shreeya Patel

> thanks,
> 
> greg k-h
>

Re: stable-rc: 5.10: arm: u64_stats_sync.h:136:2: error: implicit declaration of function 'preempt_disable_nested'

[Greg Kroah-Hartman]

On Tue, Apr 23, 2024 at 05:53:18PM +0100, Shreeya Patel wrote:
> On Tuesday, April 23, 2024 21:52 IST, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> > On Tue, Apr 23, 2024 at 01:35:28PM +0530, Naresh Kamboju wrote:
> > > The arm and i386 builds failed with clang-17 and gcc-12 on stable-rc
> > > linux.5.10.y
> > > branch with linked config [1].
> > > 
> > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > > 
> > > In file included from init/do_mounts.c:7:
> > > In file included from include/linux/suspend.h:5:
> > > In file included from include/linux/swap.h:9:
> > > In file included from include/linux/memcontrol.h:13:
> > > In file included from include/linux/cgroup.h:28:
> > > In file included from include/linux/cgroup-defs.h:20:
> > > include/linux/u64_stats_sync.h:136:2: error: implicit declaration of
> > > function 'preempt_disable_nested'
> > > [-Werror,-Wimplicit-function-declaration]
> > >   136 |         preempt_disable_nested();
> > >       |         ^
> > 
> > That function is not in the queue at all, are you sure you are up to
> > date?
> > 
> 
> Hi Greg,
> 
> Just to add, KernelCI has also reported these failures on stable-rc 5.10 kernel recently.
> Following are the details for it :-
> 
> 32r2el_defconfig ‐ mips ‐ gcc-101 warning — 2 errors
> allnoconfig ‐ i386 ‐ gcc-101 warning — 2 errors
> haps_hs_smp_defconfig ‐ arc ‐ gcc-107 warnings — 14 errors
> i386_defconfig ‐ i386 ‐ gcc-101 warning — 2 errors
> imx_v6_v7_defconfig ‐ arm ‐ gcc-107 warnings — 14 errors
> multi_v5_defconfig ‐ arm ‐ gcc-108 warnings — 16 errors
> multi_v7_defconfig ‐ arm ‐ gcc-107 warnings — 14 errors
> omap2plus_defconfig ‐ arm ‐ gcc-108 warnings — 16 errors
> rv32_defconfig ‐ riscv ‐ gcc-1010 warnings — 16 errors
> tinyconfig ‐ i386 ‐ gcc-101 warning — 2 errors
> vexpress_defconfig ‐ arm ‐ gcc-109 warnings — 18 errors
> 
> Build Logs Summary
> Errors Summary
> include/linux/u64_stats_sync.h:143:2: error: implicit declaration of function ‘preempt_enable_nested’; did you mean ‘preempt_enable_no_resched’? [-Werror=implicit-function-declaration]
> include/linux/u64_stats_sync.h:136:2: error: implicit declaration of function ‘preempt_disable_nested’; did you mean ‘preempt_disable_notrace’? [-Werror=implicit-function-declaration]
> include/linux/u64_stats_sync.h:143:2: error: implicit declaration of function 'preempt_enable_nested'; did you mean 'preempt_enable_no_resched'? [-Werror=implicit-function-declaration]
> include/linux/u64_stats_sync.h:136:2: error: implicit declaration of function 'preempt_disable_nested'; did you mean 'preempt_disable_notrace'? [-Werror=implicit-function-declaration]

Again, very odd, I do not see that anywhere in the patch queue.  I've
updated the -rc git tree, perhaps an old version was in there somehow...

thanks,

greg k-h

Re: stable-rc: 5.10: arm: u64_stats_sync.h:136:2: error: implicit declaration of function 'preempt_disable_nested'

[Dan Carpenter]

On Tue, Apr 23, 2024 at 09:59:58AM -0700, Greg Kroah-Hartman wrote:
> > Build Logs Summary
> > Errors Summary
> > include/linux/u64_stats_sync.h:143:2: error: implicit declaration of function ‘preempt_enable_nested’; did you mean ‘preempt_enable_no_resched’? [-Werror=implicit-function-declaration]
> > include/linux/u64_stats_sync.h:136:2: error: implicit declaration of function ‘preempt_disable_nested’; did you mean ‘preempt_disable_notrace’? [-Werror=implicit-function-declaration]
> > include/linux/u64_stats_sync.h:143:2: error: implicit declaration of function 'preempt_enable_nested'; did you mean 'preempt_enable_no_resched'? [-Werror=implicit-function-declaration]
> > include/linux/u64_stats_sync.h:136:2: error: implicit declaration of function 'preempt_disable_nested'; did you mean 'preempt_disable_notrace'? [-Werror=implicit-function-declaration]
> 
> Again, very odd, I do not see that anywhere in the patch queue.  I've
> updated the -rc git tree, perhaps an old version was in there somehow...
> 

Yep.  Seems to be solved on our end as well.

regards,
dan carpenter