From: Greg KH <greg@kroah.com>
To: Lokesh Gidra <lokeshgidra@google.com>
Cc: stable@vger.kernel.org, surenb@google.com,
David Hildenbrand <david@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Kalesh Singh <kaleshsingh@google.com>,
Nicolas Geoffray <ngeoffray@google.com>,
Peter Xu <peterx@redhat.com>,
Qi Zheng <zhengqi.arch@bytedance.com>,
Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 6.8.y] userfaultfd: change src_folio after ensuring it's unpinned in UFFDIO_MOVE
Date: Tue, 23 Apr 2024 11:00:46 -0700 [thread overview]
Message-ID: <2024042339-jumble-graceless-b141@gregkh> (raw)
In-Reply-To: <20240423175238.1258250-1-lokeshgidra@google.com>
On Tue, Apr 23, 2024 at 10:52:38AM -0700, Lokesh Gidra wrote:
> Commit d7a08838ab74 ("mm: userfaultfd: fix unexpected change to src_folio
> when UFFDIO_MOVE fails") moved the src_folio->{mapping, index} changing to
> after clearing the page-table and ensuring that it's not pinned. This
> avoids failure of swapout+migration and possibly memory corruption.
>
> However, the commit missed fixing it in the huge-page case.
>
> Link: https://lkml.kernel.org/r/20240404171726.2302435-1-lokeshgidra@google.com
> Fixes: adef440691ba ("userfaultfd: UFFDIO_MOVE uABI")
> Signed-off-by: Lokesh Gidra <lokeshgidra@google.com>
> Acked-by: David Hildenbrand <david@redhat.com>
> Cc: Andrea Arcangeli <aarcange@redhat.com>
> Cc: Kalesh Singh <kaleshsingh@google.com>
> Cc: Lokesh Gidra <lokeshgidra@google.com>
> Cc: Nicolas Geoffray <ngeoffray@google.com>
> Cc: Peter Xu <peterx@redhat.com>
> Cc: Qi Zheng <zhengqi.arch@bytedance.com>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> (cherry picked from commit c0205eaf3af9f5db14d4b5ee4abacf4a583c3c50)
> Signed-off-by: Lokesh Gidra <lokeshgidra@google.com>
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2024-04-23 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 13:10 FAILED: patch "[PATCH] userfaultfd: change src_folio after ensuring it's unpinned in" failed to apply to 6.8-stable tree gregkh
2024-04-23 17:52 ` [PATCH 6.8.y] userfaultfd: change src_folio after ensuring it's unpinned in UFFDIO_MOVE Lokesh Gidra
2024-04-23 18:00 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024042339-jumble-graceless-b141@gregkh \
--to=greg@kroah.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=kaleshsingh@google.com \
--cc=lokeshgidra@google.com \
--cc=ngeoffray@google.com \
--cc=peterx@redhat.com \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=willy@infradead.org \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox