Re: [PATCH 6.6 073/158] usb: pci-quirks: handle HAS_IOPORT dependency for AMD quirk

Greg Kroah-Hartman
2024-04-27T14:05:22Z

On Wed, Apr 24, 2024 at 08:27:39AM +0200, Arnd Bergmann wrote:
> On Tue, Apr 23, 2024, at 23:38, Greg Kroah-Hartman wrote:
> > 6.6-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Niklas Schnelle <schnelle@linux.ibm.com>
> >
> > [ Upstream commit 52e24f8c0a102ac76649c6b71224fadcc82bd5da ]
> >
> > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> > not being declared. In the pci-quirks case the I/O port acceses are
> > used in the quirks for several AMD south bridges, Add a config option
> > for the AMD quirks to depend on HAS_IOPORT and #ifdef the quirk code.
> >
> > Co-developed-by: Arnd Bergmann <arnd@kernel.org>
> > Signed-off-by: Arnd Bergmann <arnd@kernel.org>
> > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> > Link: https://lore.kernel.org/r/20230911125653.1393895-3-schnelle@linux.ibm.com
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
> > ---
> > drivers/usb/Kconfig | 10 ++++++++++
> > drivers/usb/core/hcd-pci.c | 3 +--
> > drivers/usb/host/pci-quirks.c | 2 ++
> > drivers/usb/host/pci-quirks.h | 30 ++++++++++++++++++++++--------
> > include/linux/usb/hcd.h | 17 +++++++++++++++++
> > 5 files changed, 52 insertions(+), 10 deletions(-)
>
> There is no harm in backporting this one to 6.6, but there
> is no need either since it is only a preparation for the coming
> changes to asm/io.h.
>
> Like the PCI quirks patch, I wouldn't backport it at all.
> If you do want to keep it, be careful about backporting it
> to older kernels, as it depends on fcbfe8121a45 ("Kconfig:
> introduce HAS_IOPORT option and select it as necessary") from
> linux-6.4.

Agreed, I've dropped all of these now, thanks.

greg k-h