* FAILED: patch "[PATCH] rust: remove `params` from `module` macro example" failed to apply to 6.1-stable tree
@ 2024-04-29 11:21 gregkh
2024-04-29 12:45 ` [PATCH 6.1.y] rust: remove `params` from `module` macro example Miguel Ojeda
0 siblings, 1 reply; 3+ messages in thread
From: gregkh @ 2024-04-29 11:21 UTC (permalink / raw)
To: aswinunni01, aliceryhl, ojeda; +Cc: stable
The patch below does not apply to the 6.1-stable tree.
If someone wants it applied there, or to any other stable or longterm
tree, then please email the backport, including the original git commit
id to <stable@vger.kernel.org>.
To reproduce the conflict and resubmit, you may use the following commands:
git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.1.y
git checkout FETCH_HEAD
git cherry-pick -x 19843452dca40e28d6d3f4793d998b681d505c7f
# <resolve conflicts, build, test, etc.>
git commit -s
git send-email --to '<stable@vger.kernel.org>' --in-reply-to '2024042924-ribcage-browsing-7e8b@gregkh' --subject-prefix 'PATCH 6.1.y' HEAD^..
Possible dependencies:
19843452dca4 ("rust: remove `params` from `module` macro example")
b13c9880f909 ("rust: macros: take string literals in `module!`")
c3630df66f95 ("rust: samples: add `rust_print` example")
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 19843452dca40e28d6d3f4793d998b681d505c7f Mon Sep 17 00:00:00 2001
From: Aswin Unnikrishnan <aswinunni01@gmail.com>
Date: Fri, 19 Apr 2024 21:50:13 +0000
Subject: [PATCH] rust: remove `params` from `module` macro example
Remove argument `params` from the `module` macro example, because the
macro does not currently support module parameters since it was not sent
with the initial merge.
Signed-off-by: Aswin Unnikrishnan <aswinunni01@gmail.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Cc: stable@vger.kernel.org
Fixes: 1fbde52bde73 ("rust: add `macros` crate")
Link: https://lore.kernel.org/r/20240419215015.157258-1-aswinunni01@gmail.com
[ Reworded slightly. ]
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
diff --git a/rust/macros/lib.rs b/rust/macros/lib.rs
index f489f3157383..520eae5fd792 100644
--- a/rust/macros/lib.rs
+++ b/rust/macros/lib.rs
@@ -35,18 +35,6 @@ use proc_macro::TokenStream;
/// author: "Rust for Linux Contributors",
/// description: "My very own kernel module!",
/// license: "GPL",
-/// params: {
-/// my_i32: i32 {
-/// default: 42,
-/// permissions: 0o000,
-/// description: "Example of i32",
-/// },
-/// writeable_i32: i32 {
-/// default: 42,
-/// permissions: 0o644,
-/// description: "Example of i32",
-/// },
-/// },
/// }
///
/// struct MyModule;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 6.1.y] rust: remove `params` from `module` macro example
2024-04-29 11:21 FAILED: patch "[PATCH] rust: remove `params` from `module` macro example" failed to apply to 6.1-stable tree gregkh
@ 2024-04-29 12:45 ` Miguel Ojeda
2024-04-29 13:45 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Miguel Ojeda @ 2024-04-29 12:45 UTC (permalink / raw)
To: stable; +Cc: Aswin Unnikrishnan, Alice Ryhl, Miguel Ojeda
From: Aswin Unnikrishnan <aswinunni01@gmail.com>
Remove argument `params` from the `module` macro example, because the
macro does not currently support module parameters since it was not sent
with the initial merge.
Signed-off-by: Aswin Unnikrishnan <aswinunni01@gmail.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Cc: stable@vger.kernel.org
Fixes: 1fbde52bde73 ("rust: add `macros` crate")
Link: https://lore.kernel.org/r/20240419215015.157258-1-aswinunni01@gmail.com
[ Reworded slightly. ]
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
(cherry picked from commit 19843452dca40e28d6d3f4793d998b681d505c7f)
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
---
rust/macros/lib.rs | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/rust/macros/lib.rs b/rust/macros/lib.rs
index 91764bfb1f89..f2efa86a747a 100644
--- a/rust/macros/lib.rs
+++ b/rust/macros/lib.rs
@@ -27,18 +27,6 @@ use proc_macro::TokenStream;
/// author: b"Rust for Linux Contributors",
/// description: b"My very own kernel module!",
/// license: b"GPL",
-/// params: {
-/// my_i32: i32 {
-/// default: 42,
-/// permissions: 0o000,
-/// description: b"Example of i32",
-/// },
-/// writeable_i32: i32 {
-/// default: 42,
-/// permissions: 0o644,
-/// description: b"Example of i32",
-/// },
-/// },
/// }
///
/// struct MyModule;
--
2.44.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 6.1.y] rust: remove `params` from `module` macro example
2024-04-29 12:45 ` [PATCH 6.1.y] rust: remove `params` from `module` macro example Miguel Ojeda
@ 2024-04-29 13:45 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2024-04-29 13:45 UTC (permalink / raw)
To: Miguel Ojeda; +Cc: stable, Aswin Unnikrishnan, Alice Ryhl
On Mon, Apr 29, 2024 at 02:45:05PM +0200, Miguel Ojeda wrote:
> From: Aswin Unnikrishnan <aswinunni01@gmail.com>
>
> Remove argument `params` from the `module` macro example, because the
> macro does not currently support module parameters since it was not sent
> with the initial merge.
>
> Signed-off-by: Aswin Unnikrishnan <aswinunni01@gmail.com>
> Reviewed-by: Alice Ryhl <aliceryhl@google.com>
> Cc: stable@vger.kernel.org
> Fixes: 1fbde52bde73 ("rust: add `macros` crate")
> Link: https://lore.kernel.org/r/20240419215015.157258-1-aswinunni01@gmail.com
> [ Reworded slightly. ]
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> (cherry picked from commit 19843452dca40e28d6d3f4793d998b681d505c7f)
> Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
> ---
> rust/macros/lib.rs | 12 ------------
> 1 file changed, 12 deletions(-)
Now queued up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-29 13:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-29 11:21 FAILED: patch "[PATCH] rust: remove `params` from `module` macro example" failed to apply to 6.1-stable tree gregkh
2024-04-29 12:45 ` [PATCH 6.1.y] rust: remove `params` from `module` macro example Miguel Ojeda
2024-04-29 13:45 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).