From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DB6F12C805; Tue, 30 Apr 2024 11:21:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714476088; cv=none; b=IqYyN7nbEBkKp1YUsjP7PYfBwjrzEQbtXMYJCcs0Kkg4QpnE6v6bavj5fBEXszCZ1q2pmpi7ZwoTZb4/xWDfHEErENlBfdoeRwzm9I4ZkPshiYwekNULMDs+j21I0XJNFYg30a/YXyW1IrC1F8SWn1sx2yZbdkYNC73S+k5cNp8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714476088; c=relaxed/simple; bh=uHhMbJX/tj6aP0gocKNsXJ7EhVRajLf4dv4erULeQl0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pv1itJxYfcM8oqHQ82vUT+nRB5Dgd6UZ40uDfjnr6jKpHcn+Nhjz5bzYXGZ4odrh81LoSYl610vqxc4YfWzCXTje5Y4SZpM3WSWLY6lXY7oQF5H7Ff2WuDq3crWdRoCos/iMi1WC9JTu3rQaocIS4eqRK/U8pf3ntbpVdke6XqQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=orygfRat; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="orygfRat" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C839C4AF1A; Tue, 30 Apr 2024 11:21:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1714476088; bh=uHhMbJX/tj6aP0gocKNsXJ7EhVRajLf4dv4erULeQl0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=orygfRatyhy4/bk4q9ORt7tVXA5lwkahWThs76res+5gqI/m2i6jUwYEJ1gCT88DD /nTsyvnkYXGNzfRsDaBn0XILWEaNxOpNZDsRNYrRs+TcOe1iaZWm3LB5NqGjhoIN7v Vj3m+6x82rtMrRvNaxFqGl6h/uzYMSx9VM9uq8KI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Arnd Bergmann , Danilo Krummrich , Sasha Levin Subject: [PATCH 5.4 003/107] nouveau: fix function cast warning Date: Tue, 30 Apr 2024 12:39:23 +0200 Message-ID: <20240430103044.759249028@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240430103044.655968143@linuxfoundation.org> References: <20240430103044.655968143@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arnd Bergmann [ Upstream commit 185fdb4697cc9684a02f2fab0530ecdd0c2f15d4 ] Calling a function through an incompatible pointer type causes breaks kcfi, so clang warns about the assignment: drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowof.c:73:10: error: cast from 'void (*)(const void *)' to 'void (*)(void *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict] 73 | .fini = (void(*)(void *))kfree, Avoid this with a trivial wrapper. Fixes: c39f472e9f14 ("drm/nouveau: remove symlinks, move core/ to nvkm/ (no code changes)") Signed-off-by: Arnd Bergmann Signed-off-by: Danilo Krummrich Link: https://patchwork.freedesktop.org/patch/msgid/20240404160234.2923554-1-arnd@kernel.org Signed-off-by: Sasha Levin --- drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowof.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowof.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowof.c index 4bf486b571013..cb05f7f48a98b 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowof.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowof.c @@ -66,11 +66,16 @@ of_init(struct nvkm_bios *bios, const char *name) return ERR_PTR(-EINVAL); } +static void of_fini(void *p) +{ + kfree(p); +} + const struct nvbios_source nvbios_of = { .name = "OpenFirmware", .init = of_init, - .fini = (void(*)(void *))kfree, + .fini = of_fini, .read = of_read, .size = of_size, .rw = false, -- 2.43.0