From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F3A717592; Tue, 30 Apr 2024 11:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714476136; cv=none; b=Y3UjLTYxAx3ubi5/1KxEz+U9DuGX/ETWabx2DXvYHAmG8a0bZ2JZhKNLK8ItmHY0oKdLs3LpCzEuLA4lHYKdyF+snHT2W+FaZkZ69PDvHY8la+6tFLCmaqJx6zPGcJmwNQ6JM44bAD6GsrN/BzOhgeI3iWWTMfxnd1gePOuIwMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714476136; c=relaxed/simple; bh=SdKUnH21HoQ3pycF4VoZLScAdJXYRzXzorQpVroB2Kg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VA/IFh5dNliv3nLV4MQm4cgcGjG0iMJuz5CpJPQLmJVqMW+J4f8Q+ZyB7zx7Nu/ZFEd06cPzs8eTjerlnkRWJD25pIksirtrdtCEkTu/GWqfTg/e3Xxg8BbHQoRkBAjHXyP1Uz9D5Zq0d2KWpxizh8S76mMidENb7tjKlbsIko4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XwHNXqq1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XwHNXqq1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C690AC4AF49; Tue, 30 Apr 2024 11:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1714476136; bh=SdKUnH21HoQ3pycF4VoZLScAdJXYRzXzorQpVroB2Kg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XwHNXqq1kOhXkOpOrCm++b8LsdFLKZDQOP0tIxRPpkJg5PEOUqBo1zAyJATgtkvFZ ptp9ezwy6FigCA9EW1PKrZplgtfiQlvrUziL9Q06JRjjVasxrBeYYqB7dgU2aZkB/j DH8E+ao9FehACyDQsgi6AyJJuM1cP7n4dmIrTpek= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, David Ahern , Arnd Bergmann , Eric Dumazet , Paolo Abeni , Sasha Levin Subject: [PATCH 5.4 008/107] ipv4/route: avoid unused-but-set-variable warning Date: Tue, 30 Apr 2024 12:39:28 +0200 Message-ID: <20240430103044.904563692@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240430103044.655968143@linuxfoundation.org> References: <20240430103044.655968143@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arnd Bergmann [ Upstream commit cf1b7201df59fb936f40f4a807433fe3f2ce310a ] The log_martians variable is only used in an #ifdef, causing a 'make W=1' warning with gcc: net/ipv4/route.c: In function 'ip_rt_send_redirect': net/ipv4/route.c:880:13: error: variable 'log_martians' set but not used [-Werror=unused-but-set-variable] Change the #ifdef to an equivalent IS_ENABLED() to let the compiler see where the variable is used. Fixes: 30038fc61adf ("net: ip_rt_send_redirect() optimization") Reviewed-by: David Ahern Signed-off-by: Arnd Bergmann Reviewed-by: Eric Dumazet Link: https://lore.kernel.org/r/20240408074219.3030256-2-arnd@kernel.org Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- net/ipv4/route.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 902296ef3e5aa..5b008d838e2b9 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -945,13 +945,11 @@ void ip_rt_send_redirect(struct sk_buff *skb) icmp_send(skb, ICMP_REDIRECT, ICMP_REDIR_HOST, gw); peer->rate_last = jiffies; ++peer->n_redirects; -#ifdef CONFIG_IP_ROUTE_VERBOSE - if (log_martians && + if (IS_ENABLED(CONFIG_IP_ROUTE_VERBOSE) && log_martians && peer->n_redirects == ip_rt_redirect_number) net_warn_ratelimited("host %pI4/if%d ignores redirects for %pI4 to %pI4\n", &ip_hdr(skb)->saddr, inet_iif(skb), &ip_hdr(skb)->daddr, &gw); -#endif } out_put_peer: inet_putpeer(peer); -- 2.43.0