From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3656F8801; Tue, 30 Apr 2024 11:20:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714476050; cv=none; b=sNRBNO0Bqn8igw6VpA4YYu5W0CpG758WS5rQrKM7UzziTArx7rqONIZ5aNSL49ZWmU2TruejdvlOxUVEybJKnmW9VcX9SjR57vee0SbxUENQZ3/2IFJo8th4oNxtWegO7cpDtQhVVCmM6BnNa/2faaDfWNzjXfstM9rLxo0CZA8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714476050; c=relaxed/simple; bh=MTwyskTR5CZjYLylqaxqEEHNO8DrBrpucGPRg0nk9t4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=knXZ/HsM7IAXt2gBCupwsaw/o56IXUsUy80WJFZsFCk1FFpkIG9phb5PCwwNAGKT9vctDftUzJGWTC2zbh6AcwGqYWhTF+gOQYAue4E5l/FWWhLF0LgdNRbJALxZXPgrXZ/3+x8RgwNNIIDpj70wfB4aNk+Xfx9K+/7jUlcl2CA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WMWTvbMX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WMWTvbMX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2E7CC2BBFC; Tue, 30 Apr 2024 11:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1714476050; bh=MTwyskTR5CZjYLylqaxqEEHNO8DrBrpucGPRg0nk9t4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WMWTvbMXzLec/Su2jfTRPhBJVaTLyt59FQx68kBlMg99L0JSalgLHTU04pv87bqRW wlEyuFykJ/RHllaXMNSk4dEMPhr//oJmKqAcehLEKtyHaWMGaxIKjeIyg9vJZPCoun oDL+M46LzeBUTdxUeDE9NO06VZnJp3uxJEd/tq00= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Qu Wenruo , Boris Burkov , David Sterba , Sasha Levin Subject: [PATCH 5.4 019/107] btrfs: record delayed inode root in transaction Date: Tue, 30 Apr 2024 12:39:39 +0200 Message-ID: <20240430103045.230736525@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240430103044.655968143@linuxfoundation.org> References: <20240430103044.655968143@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Boris Burkov [ Upstream commit 71537e35c324ea6fbd68377a4f26bb93a831ae35 ] When running delayed inode updates, we do not record the inode's root in the transaction, but we do allocate PREALLOC and thus converted PERTRANS space for it. To be sure we free that PERTRANS meta rsv, we must ensure that we record the root in the transaction. Fixes: 4f5427ccce5d ("btrfs: delayed-inode: Use new qgroup meta rsv for delayed inode and item") CC: stable@vger.kernel.org # 6.1+ Reviewed-by: Qu Wenruo Signed-off-by: Boris Burkov Signed-off-by: David Sterba Signed-off-by: Sasha Levin --- fs/btrfs/delayed-inode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c index eacc020b1419f..95afe5ef7500c 100644 --- a/fs/btrfs/delayed-inode.c +++ b/fs/btrfs/delayed-inode.c @@ -1137,6 +1137,9 @@ __btrfs_commit_inode_delayed_items(struct btrfs_trans_handle *trans, if (ret) return ret; + ret = btrfs_record_root_in_trans(trans, node->root); + if (ret) + return ret; ret = btrfs_update_delayed_inode(trans, node->root, path, node); return ret; } -- 2.43.0