From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A38812C462; Tue, 30 Apr 2024 11:04:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714475088; cv=none; b=WI4uZCJjPXp+8Hw4oEd4KdJP/Rzr/Kr9Oydcw3QySod3fsfsDRWlpL5/RyWIt4q641D+cKCfVSfIKrjE9/GysMfdmxUPSuw+K+MxO69aElCRJoBrWwcRRDJgjVikWq4IFMXHB5c/MLEOUQT5rHceKwsLZ6whfWOdFMZrc/tbtC8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714475088; c=relaxed/simple; bh=Zf5F954FSU7NTybDY6wbVyBtX86yo6MBrWpv7C2clds=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cTVdFsr2aaib5mjlbyFFzu3Cq4EF8cMNcVJ6OvjHq6uU1NH5dGgn1EG/6PfUbSuG5bUhtTOlPtwNy+PxyBqN2KwA+V3UDbBe8XTwf8fNuDUEUNiVndaaf4O/YPEBdrkyU9m0FgIO+/XDhbtfzrpqhbw4omCWD4567nkRNdnj9Gc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JnbfzMuy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JnbfzMuy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7EE6C2BBFC; Tue, 30 Apr 2024 11:04:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1714475088; bh=Zf5F954FSU7NTybDY6wbVyBtX86yo6MBrWpv7C2clds=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JnbfzMuyzw6/6j+mbK8ARfOkTE41NfPvONju2aM3Spepq5JF+iOC5lF6P+hrFyEcK VPdaayH0gmEYTQA+ugAgasv5Dk+Tj6qYRXe0nkWX6Mc14cE06mKs+Omb+ODEAikfIe PXSSCaWq5coJDi7ixgjEqsjm7X7LSiCAS8Y2aQPI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, shironeko , Eric Dumazet , Jose Alonso , Simon Horman , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 089/138] net: usb: ax88179_178a: stop lying about skb->truesize Date: Tue, 30 Apr 2024 12:39:34 +0200 Message-ID: <20240430103052.040961091@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240430103049.422035273@linuxfoundation.org> References: <20240430103049.422035273@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet [ Upstream commit 4ce62d5b2f7aecd4900e7d6115588ad7f9acccca ] Some usb drivers try to set small skb->truesize and break core networking stacks. In this patch, I removed one of the skb->truesize overide. I also replaced one skb_clone() by an allocation of a fresh and small skb, to get minimally sized skbs, like we did in commit 1e2c61172342 ("net: cdc_ncm: reduce skb truesize in rx path") Fixes: f8ebb3ac881b ("net: usb: ax88179_178a: Fix packet receiving") Reported-by: shironeko Closes: https://lore.kernel.org/netdev/c110f41a0d2776b525930f213ca9715c@tesaguri.club/ Signed-off-by: Eric Dumazet Cc: Jose Alonso Reviewed-by: Simon Horman Link: https://lore.kernel.org/r/20240421193828.1966195-1-edumazet@google.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/usb/ax88179_178a.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index 38cb863ccb911..da4a2427b005f 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -1558,21 +1558,16 @@ static int ax88179_rx_fixup(struct usbnet *dev, struct sk_buff *skb) /* Skip IP alignment pseudo header */ skb_pull(skb, 2); - skb->truesize = SKB_TRUESIZE(pkt_len_plus_padd); ax88179_rx_checksum(skb, pkt_hdr); return 1; } - ax_skb = skb_clone(skb, GFP_ATOMIC); + ax_skb = netdev_alloc_skb_ip_align(dev->net, pkt_len); if (!ax_skb) return 0; - skb_trim(ax_skb, pkt_len); + skb_put(ax_skb, pkt_len); + memcpy(ax_skb->data, skb->data + 2, pkt_len); - /* Skip IP alignment pseudo header */ - skb_pull(ax_skb, 2); - - skb->truesize = pkt_len_plus_padd + - SKB_DATA_ALIGN(sizeof(struct sk_buff)); ax88179_rx_checksum(ax_skb, pkt_hdr); usbnet_skb_return(dev, ax_skb); -- 2.43.0