From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8356312C462; Tue, 30 Apr 2024 11:05:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714475101; cv=none; b=HPKSF9csnJfwYYvNCugXtAzTeZd0MbvEk0X3wQauXETNCmLBXgnDDs2/k5xhrWxZfPbMI4bsWHmRRIuOYqAwAg80FTjV7DqafneSRBmFxKo3ki8ql0MnQkpkb2zH+Re1ie48T0N9OONW4OEdFtKPTuPCcZqCHiGIXUgPUDuz3mQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714475101; c=relaxed/simple; bh=EcSrvuPDDzoxJbD5tokqF6mYopUaGKakWcsvvXrGwfs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BYvkAr92cKQbD3cekQ9bHJj+IRWqhtnTUibTGCDaxOFm+xxYfM9SuzRiix/W6VnNk+vUcoEF0sOGMTY+6NNI2cL5woE1fsDlfYO0QPNlIBMyVXCRsaJtMcJxTo9LyVpkBtzSntiASOeaHNfrtIbPub0TJjhx4UsGuzHLrrikvBM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hmpoCcYy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hmpoCcYy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07542C2BBFC; Tue, 30 Apr 2024 11:05:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1714475101; bh=EcSrvuPDDzoxJbD5tokqF6mYopUaGKakWcsvvXrGwfs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hmpoCcYypP73etCwxa+Ks6K4a6lEKO0oIFnX18VvghMf2QEK7x3Qju7+eQKTw9ohL zvUDO8vKeocTvGDuY6KJd3DZBQs6ICfcB70XpbGJg/P+w/yE/TWexeFFdNwFhZD75o V1kZOrFbypVUiDW3wd7T9X1R72tfJSpcuDCZB8a0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Baruch Siach , Wolfram Sang , Sasha Levin Subject: [PATCH 5.10 133/138] i2c: smbus: fix NULL function pointer dereference Date: Tue, 30 Apr 2024 12:40:18 +0200 Message-ID: <20240430103053.316745832@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240430103049.422035273@linuxfoundation.org> References: <20240430103049.422035273@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Wolfram Sang [ Upstream commit 91811a31b68d3765b3065f4bb6d7d6d84a7cfc9f ] Baruch reported an OOPS when using the designware controller as target only. Target-only modes break the assumption of one transfer function always being available. Fix this by always checking the pointer in __i2c_transfer. Reported-by: Baruch Siach Closes: https://lore.kernel.org/r/4269631780e5ba789cf1ae391eec1b959def7d99.1712761976.git.baruch@tkos.co.il Fixes: 4b1acc43331d ("i2c: core changes for slave support") [wsa: dropped the simplification in core-smbus to avoid theoretical regressions] Signed-off-by: Wolfram Sang Tested-by: Baruch Siach Signed-off-by: Sasha Levin --- drivers/i2c/i2c-core-base.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index 34fecf97a355b..e8a89e18c640e 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -2013,13 +2013,18 @@ static int i2c_check_for_quirks(struct i2c_adapter *adap, struct i2c_msg *msgs, * Returns negative errno, else the number of messages executed. * * Adapter lock must be held when calling this function. No debug logging - * takes place. adap->algo->master_xfer existence isn't checked. + * takes place. */ int __i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) { unsigned long orig_jiffies; int ret, try; + if (!adap->algo->master_xfer) { + dev_dbg(&adap->dev, "I2C level transfers not supported\n"); + return -EOPNOTSUPP; + } + if (WARN_ON(!msgs || num < 1)) return -EINVAL; @@ -2086,11 +2091,6 @@ int i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) { int ret; - if (!adap->algo->master_xfer) { - dev_dbg(&adap->dev, "I2C level transfers not supported\n"); - return -EOPNOTSUPP; - } - /* REVISIT the fault reporting model here is weak: * * - When we get an error after receiving N bytes from a slave, -- 2.43.0