From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 946291E50A; Tue, 30 Apr 2024 11:10:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714475420; cv=none; b=hhL0EYvjjc0v5C4CcbbhSukNYfhvfA+MF+rO1J5rqw6cNOFRstfwFxmm7bKZKRwCbCrRyztEpE32Vu0LuhvoFQODmVC9Q1+jfH3QzbZxtOdAdFmV39OSCfHjhY4UxD8agAWEfS6JVrd8wET9s/rEueY1q0bJemzlDEQZvNR3avE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714475420; c=relaxed/simple; bh=DH7HNXwQ5Cvn6FPjNJUr0f4CwvhhKNfgHRhgxRBtsOY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XS3v0oGTg7OO1UAO0YHG1vhiA55pLVImrAg7vLakDIuP3XNcECzzJ5RVau/OJBP7hKzrM6M3nAUnHPqTJmrQLdyIIPakgqG3hzDC9WDnSlEsZbuMx03rEeq3h7CIRPOGou8p07bR/eE0dfmfC/fw5C2w1GcDqhHMFW88HbtKZ/4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=aw3/CrrK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="aw3/CrrK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BFD4C2BBFC; Tue, 30 Apr 2024 11:10:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1714475420; bh=DH7HNXwQ5Cvn6FPjNJUr0f4CwvhhKNfgHRhgxRBtsOY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aw3/CrrKUvO6Vr5p7zHGkUQvavLrHVPNn+nuo59uohwQoUbVjlNwyHFlXxz1TkLJM DrRhdyYRsdQN4iS1nHvNvwJBLkwMQBAihs/kkIdf075GK/heAfpXgQLXTQLk4oQOS5 MPSMwHBJuJBHc+87VZHFEihM2WyqPu28QHPf0KUI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Erwan Velu , Simon Horman , Tony Brelinski , Tony Nguyen , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.6 090/186] i40e: Report MFS in decimal base instead of hex Date: Tue, 30 Apr 2024 12:39:02 +0200 Message-ID: <20240430103100.645694978@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240430103058.010791820@linuxfoundation.org> References: <20240430103058.010791820@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Erwan Velu [ Upstream commit ef3c313119ea448c22da10366faa26b5b4b1a18e ] If the MFS is set below the default (0x2600), a warning message is reported like the following : MFS for port 1 has been set below the default: 600 This message is a bit confusing as the number shown here (600) is in fact an hexa number: 0x600 = 1536 Without any explicit "0x" prefix, this message is read like the MFS is set to 600 bytes. MFS, as per MTUs, are usually expressed in decimal base. This commit reports both current and default MFS values in decimal so it's less confusing for end-users. A typical warning message looks like the following : MFS for port 1 (1536) has been set below the default (9728) Signed-off-by: Erwan Velu Reviewed-by: Simon Horman Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen Fixes: 3a2c6ced90e1 ("i40e: Add a check to see if MFS is set") Link: https://lore.kernel.org/r/20240423182723.740401-3-anthony.l.nguyen@intel.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c index 54d3bd8ec5ea3..f8d1a994c2f65 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -16237,8 +16237,8 @@ static int i40e_probe(struct pci_dev *pdev, const struct pci_device_id *ent) val = (rd32(&pf->hw, I40E_PRTGL_SAH) & I40E_PRTGL_SAH_MFS_MASK) >> I40E_PRTGL_SAH_MFS_SHIFT; if (val < MAX_FRAME_SIZE_DEFAULT) - dev_warn(&pdev->dev, "MFS for port %x has been set below the default: %x\n", - pf->hw.port, val); + dev_warn(&pdev->dev, "MFS for port %x (%d) has been set below the default (%d)\n", + pf->hw.port, val, MAX_FRAME_SIZE_DEFAULT); /* Add a filter to drop all Flow control frames from any VSI from being * transmitted. By doing so we stop a malicious VF from sending out -- 2.43.0