From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0486211C; Tue, 30 Apr 2024 11:13:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714475629; cv=none; b=AXa37pqVgF51703q978t2xLl1IK/c0IL3w0TLfDpoKkuzsSJwQQGakCAH5q/wA7Ojd1nrsEe3ki8EWPHoomOn27q004Grgzc0ICGzqAPYrQwgh7FIxAEf129MiveKBncsFkEfnjBLy9UfcSumV+GjjRwc5n3Ltn5I7BENgqF6ck= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714475629; c=relaxed/simple; bh=ocUHaCR5VhFkzBvzAuPGqa8FS/z/qxShnf5xBJugNWg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZXg2rjL06HajpZUi/YzzIRaghZIr9WEL5euRKo9Mrkwxfc2zQPe9TrxekgwyJ7giQd7HqiY6xiY6CqoHQ3VTTxEqw8JqoDfxpKx48dys/ZHXMVma1MJ0v/qmIncC95YOxxWHCNkVhMOEtPJBPPukkQwukGBL8OGVfENd8TCV2mk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=c5v2ym37; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="c5v2ym37" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D25B6C2BBFC; Tue, 30 Apr 2024 11:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1714475629; bh=ocUHaCR5VhFkzBvzAuPGqa8FS/z/qxShnf5xBJugNWg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c5v2ym37tjTB4NExF774E75g8lZVsAUqeP3dF29EkNl75Ius87Ztz2l2JR8lrs8Ql B4FhMOcWVbgbS6m8QLX2BIpMxqvRinkglyLnJpB/ZsEs2dt41vSpcasE2ANxeTgNlC 4Y75qFSOre/NEzia50JcFu7yJYsxlt+KmPWnea9g= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Douglas Anderson , Abhinav Kumar , Dmitry Baryshkov , Neil Armstrong , Abel Vesa , Steev Klimaszewski , Johan Hovold , Bjorn Andersson , Stephen Boyd , Vinod Koul Subject: [PATCH 6.6 154/186] phy: qcom: qmp-combo: Fix register base for QSERDES_DP_PHY_MODE Date: Tue, 30 Apr 2024 12:40:06 +0200 Message-ID: <20240430103102.504458827@linuxfoundation.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240430103058.010791820@linuxfoundation.org> References: <20240430103058.010791820@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stephen Boyd commit ee13e1f3c72b9464a4d73017c060ab503eed653a upstream. The register base that was used to write to the QSERDES_DP_PHY_MODE register was 'dp_dp_phy' before commit 815891eee668 ("phy: qcom-qmp-combo: Introduce orientation variable"). There isn't any explanation in the commit why this is changed, so I suspect it was an oversight or happened while being extracted from some other series. Oddly the value being 0x4c or 0x5c doesn't seem to matter for me, so I suspect this is dead code, but that can be fixed in another patch. It's not good to write to the wrong register space, and maybe some other version of this phy relies on this. Cc: Douglas Anderson Cc: Abhinav Kumar Cc: Dmitry Baryshkov Cc: Neil Armstrong Cc: Abel Vesa Cc: Steev Klimaszewski Cc: Johan Hovold Cc: Bjorn Andersson Cc: stable@vger.kernel.org # 6.5 Fixes: 815891eee668 ("phy: qcom-qmp-combo: Introduce orientation variable") Signed-off-by: Stephen Boyd Reviewed-by: Abhinav Kumar Reviewed-by: Bjorn Andersson Reviewed-by: Dmitry Baryshkov Reviewed-by: Johan Hovold Link: https://lore.kernel.org/r/20240405000111.1450598-1-swboyd@chromium.org Signed-off-by: Vinod Koul Signed-off-by: Greg Kroah-Hartman --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -2047,9 +2047,9 @@ static bool qmp_combo_configure_dp_mode( writel(val, qmp->dp_dp_phy + QSERDES_DP_PHY_PD_CTL); if (reverse) - writel(0x4c, qmp->pcs + QSERDES_DP_PHY_MODE); + writel(0x4c, qmp->dp_dp_phy + QSERDES_DP_PHY_MODE); else - writel(0x5c, qmp->pcs + QSERDES_DP_PHY_MODE); + writel(0x5c, qmp->dp_dp_phy + QSERDES_DP_PHY_MODE); return reverse; }