From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04B9D1428F0; Tue, 7 May 2024 23:08:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715123340; cv=none; b=KqDYgK5/oMkxneq/mdvRwT14ZTarbtLjF9d0Xv75olSyS1xgJ92hwSIvIiUXb+vnL7LLpjYJFek+JnwurM4wtKzBJkOaLv5LUhQhHzBsV65IqLhhIgLWmH2R3SyQOcOj1ILh33ayfMHZNK8BsRxMcIl4jO2cen5Yzy2CS9cT1KQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715123340; c=relaxed/simple; bh=OYk/SNP9waEvg4CJG+FcCKBNcvA+ivNahBseQJQNfLY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EC8IvJJhR6IglZTNxit6UJqcZ46JLkClgjKVVsXuBDShacnEKGM6Wq3jMiqnG1aRdw1hhAHAf8tKDlT0WEpteHtPAD9X/S6Pu6aIHMm1hdkMQq+TmmW+Ys6jeIoLKQkmJiHBylHFRcvmJRUX7OzJeK5TbpTOWkjnd5EDCAB6P1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NOw+Nm6W; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NOw+Nm6W" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74008C4AF68; Tue, 7 May 2024 23:08:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715123339; bh=OYk/SNP9waEvg4CJG+FcCKBNcvA+ivNahBseQJQNfLY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NOw+Nm6W9KXanPK1YtDXRntVZR8K3BCNhpAlqqkFetjIGtnvyNSYJaTuuEwBEYrHn +drlawEC9illhYr5/xpYfUOwdcgDwDX2ewH4DRLMNoGbXQqWQAHB4P+r69uQfbPlWg LhmSx1U/ZGqDTr6f3p/QEhoxoFemI7ocNu8vCKOTpMeCsiWwHvYaoK3guFcCD42cPL rm60wLW60V/SJoJpEqWeekSRK8nb/9I1lPleReAg80RqZzxfpfNt56Iz+aztGaaJxw roxR6HPy1aTema1Ads6MaJsd1G/M6NIy+Jfut9UIk9F4RGc885J8w1Uwmt88B11Ya2 FtXSCAD2ssidw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Pierre-Louis Bossart , Mark Brown , Sasha Levin , support.opensource@diasemi.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org Subject: [PATCH AUTOSEL 6.8 31/52] ASoC: da7219-aad: fix usage of device_get_named_child_node() Date: Tue, 7 May 2024 19:06:57 -0400 Message-ID: <20240507230800.392128-31-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240507230800.392128-1-sashal@kernel.org> References: <20240507230800.392128-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.8.9 Content-Transfer-Encoding: 8bit From: Pierre-Louis Bossart [ Upstream commit e8a6a5ad73acbafd98e8fd3f0cbf6e379771bb76 ] The documentation for device_get_named_child_node() mentions this important point: " The caller is responsible for calling fwnode_handle_put() on the returned fwnode pointer. " Add fwnode_handle_put() to avoid a leaked reference. Signed-off-by: Pierre-Louis Bossart Link: https://lore.kernel.org/r/20240426153033.38500-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/da7219-aad.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7219-aad.c b/sound/soc/codecs/da7219-aad.c index 6bc068cdcbe2a..15e5e3eb592b3 100644 --- a/sound/soc/codecs/da7219-aad.c +++ b/sound/soc/codecs/da7219-aad.c @@ -671,8 +671,10 @@ static struct da7219_aad_pdata *da7219_aad_fw_to_pdata(struct device *dev) return NULL; aad_pdata = devm_kzalloc(dev, sizeof(*aad_pdata), GFP_KERNEL); - if (!aad_pdata) + if (!aad_pdata) { + fwnode_handle_put(aad_np); return NULL; + } aad_pdata->irq = i2c->irq; @@ -753,6 +755,8 @@ static struct da7219_aad_pdata *da7219_aad_fw_to_pdata(struct device *dev) else aad_pdata->adc_1bit_rpt = DA7219_AAD_ADC_1BIT_RPT_1; + fwnode_handle_put(aad_np); + return aad_pdata; } -- 2.43.0