From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3E3E2374E; Tue, 14 May 2024 11:41:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715686891; cv=none; b=lVVdrdArAhUdELut7nU3kSs/2bBDs7JlftjfMyiVqy/ZYEZ8GGHjGOpE3EWtj1j/r8fv9FS27KJxTJ82BSNmPpvDzCK5CPKHh4pWC6lJ+6RQTN3ZDRqVsLE2O62OFO+o0l4zotMKXGFvoayR0XLm/uj5z29IXEIq7gkjr0sL3a8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715686891; c=relaxed/simple; bh=boRcSuI7WezTsK2/U0Ya7Gtgzms5JUelxdutHMQgIhM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MUQTukMDv/B3P98Yz7/8q/4L937MZibqH6xs3m0DnoZHYFay2wyIRYICP/c3Oqe/M6h55WHEZXlK1G2vYn/xoH7kVBCjwtUXQhrqvNSPEOrhZYZFQvD4e0q1d+vlRL7hQvXH9Qf0eoM2BcN4YGiQsd/APdqlQ53yEkgbU4z7lHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=A9V0qvYW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="A9V0qvYW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BCF0C2BD10; Tue, 14 May 2024 11:41:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1715686891; bh=boRcSuI7WezTsK2/U0Ya7Gtgzms5JUelxdutHMQgIhM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A9V0qvYW5DLuhhdpeLTCYPJDEUV6tXr/xPLHktbqZ7I7uhf5yj+euqeVugF4RC5kl CGOKJJPze09lguJGSMPtmzwimQaL6aH2NFH2HmmBcSl6+w1xdnmr8vdmR9LriJU5Ji x4PEJdMmEwd+wSKwniVoZlESUIxxxLvDZwiqzEso= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Roded Zats , Donald Hunter , Jakub Kicinski , Sasha Levin Subject: [PATCH 4.19 50/63] rtnetlink: Correct nested IFLA_VF_VLAN_LIST attribute validation Date: Tue, 14 May 2024 12:20:11 +0200 Message-ID: <20240514100949.902776564@linuxfoundation.org> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240514100948.010148088@linuxfoundation.org> References: <20240514100948.010148088@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Roded Zats [ Upstream commit 1aec77b2bb2ed1db0f5efc61c4c1ca3813307489 ] Each attribute inside a nested IFLA_VF_VLAN_LIST is assumed to be a struct ifla_vf_vlan_info so the size of such attribute needs to be at least of sizeof(struct ifla_vf_vlan_info) which is 14 bytes. The current size validation in do_setvfinfo is against NLA_HDRLEN (4 bytes) which is less than sizeof(struct ifla_vf_vlan_info) so this validation is not enough and a too small attribute might be cast to a struct ifla_vf_vlan_info, this might result in an out of bands read access when accessing the saved (casted) entry in ivvl. Fixes: 79aab093a0b5 ("net: Update API for VF vlan protocol 802.1ad support") Signed-off-by: Roded Zats Reviewed-by: Donald Hunter Link: https://lore.kernel.org/r/20240502155751.75705-1-rzats@paloaltonetworks.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/core/rtnetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 0d3f724da78ba..9209623ab6445 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -2167,7 +2167,7 @@ static int do_setvfinfo(struct net_device *dev, struct nlattr **tb) nla_for_each_nested(attr, tb[IFLA_VF_VLAN_LIST], rem) { if (nla_type(attr) != IFLA_VF_VLAN_INFO || - nla_len(attr) < NLA_HDRLEN) { + nla_len(attr) < sizeof(struct ifla_vf_vlan_info)) { return -EINVAL; } if (len >= MAX_VLAN_LIST_LEN) -- 2.43.0