Re: [PATCH 4.19 00/63] 4.19.314-rc1 review

Greg Kroah-Hartman
2024-05-16T13:05:44Z

On Thu, May 16, 2024 at 02:24:02PM +0200, Pavel Machek wrote:
> > Vinod Koul <vkoul@kernel.org>
> > dmaengine: Revert "dmaengine: pl330: issue_pending waits until WFP state"
> > Bumyong Lee <bumyong.lee@samsung.com>
> > dmaengine: pl330: issue_pending waits until WFP state
>
> We apply patch just to revert it immediately. Rules say "- It must be
> obviously correct and tested.". You do this often, should the rules be
> fixed?

We apply patches that are cc: stable and having the change, and then the
revert, is the best way forward otherwise we get lots of complaints we
didn't take the first commit. This way all tools are happy, and people
are not confused as to why we did not take patches we should have.

greg k-h