From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49F23136647; Tue, 14 May 2024 11:42:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715686964; cv=none; b=ZMfOzkOT1geWCXaExbD9/GLfReT9/iYzBYfuaISA8YlwZYFtMkc1gE2Vi6lC78R1aDOyjkn6fDQV+zgvuIS7KTUm/WFnXxyz14au7OjH07YhoIdp2hA6byXPPPQBwTR7+ecQTY7gy800D7Y1kN9rZFhnIorp1SMctJZMpm7+kdg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715686964; c=relaxed/simple; bh=iA+PbtiBCwMZCdfoICEISRjD5xzgRsZqRuEr+rFuIz8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TDt8hKkYplN2YHnwhuPYWHQD9qwrZeswOWkeuU8OFU091NNdKaMmMWGRRbnsTolwVxyOdHdv2fjALebEA06p91EAgU4Vs2O6RAiKuFcVDR+FPd/2aOkBRUDi0JIMGf2ZCXn2SaiJIrbm3Td7UfxcYfVPt6nUhXmL7Xcv9tE5zJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=DgIj5YNU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="DgIj5YNU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86EB1C2BD10; Tue, 14 May 2024 11:42:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1715686963; bh=iA+PbtiBCwMZCdfoICEISRjD5xzgRsZqRuEr+rFuIz8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DgIj5YNU7pGLvzMZKirYoS93kPfm6X4BrvDtNr9nTjK9Ynfs1rNXmQM4ho5EiphLX 8/aofpU7tynYOn895Zdu/OT7hQbtnH38x0ounWjv4RD/bsKXfYMrKTV+6O8VNebPHT xYF+jsR0vCiWLsVFGUwzEWNdYNUOTBPXEksGiYg4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dan Carpenter , Zeng Heng , Linus Walleij , Sasha Levin Subject: [PATCH 5.4 19/84] pinctrl: devicetree: fix refcount leak in pinctrl_dt_to_map() Date: Tue, 14 May 2024 12:19:30 +0200 Message-ID: <20240514100952.416667809@linuxfoundation.org> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240514100951.686412426@linuxfoundation.org> References: <20240514100951.686412426@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zeng Heng [ Upstream commit a0cedbcc8852d6c77b00634b81e41f17f29d9404 ] If we fail to allocate propname buffer, we need to drop the reference count we just took. Because the pinctrl_dt_free_maps() includes the droping operation, here we call it directly. Fixes: 91d5c5060ee2 ("pinctrl: devicetree: fix null pointer dereferencing in pinctrl_dt_to_map") Suggested-by: Dan Carpenter Signed-off-by: Zeng Heng Reviewed-by: Dan Carpenter Message-ID: <20240415105328.3651441-1-zengheng4@huawei.com> Signed-off-by: Linus Walleij Signed-off-by: Sasha Levin --- drivers/pinctrl/devicetree.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/devicetree.c b/drivers/pinctrl/devicetree.c index 362d84c2ead44..200357094e3be 100644 --- a/drivers/pinctrl/devicetree.c +++ b/drivers/pinctrl/devicetree.c @@ -223,14 +223,16 @@ int pinctrl_dt_to_map(struct pinctrl *p, struct pinctrl_dev *pctldev) for (state = 0; ; state++) { /* Retrieve the pinctrl-* property */ propname = kasprintf(GFP_KERNEL, "pinctrl-%d", state); - if (!propname) - return -ENOMEM; + if (!propname) { + ret = -ENOMEM; + goto err; + } prop = of_find_property(np, propname, &size); kfree(propname); if (!prop) { if (state == 0) { - of_node_put(np); - return -ENODEV; + ret = -ENODEV; + goto err; } break; } -- 2.43.0