From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD840136648; Tue, 14 May 2024 11:42:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715686972; cv=none; b=cDxNuiPWKsn8PmP8skKN18r4W6UyROEmDvX6w4CD+pkOxyTXA1iHDek+WPk1hpfV3VX723Ujd8NqRIScALCC92cc9Ua++FPDjnWxj7aFufVLyWH/NI0Xtz/dE6a7MVXZ6lJqmHgLl4VD6bDm+W8V4Tx3BhX0N2cPwvTzVN7eP+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715686972; c=relaxed/simple; bh=m6GW91DfAd6C1rwRR5bhu3roPuG5SRU2n6kzhuhPPhI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GKY8npjLWTcBEwQ3v+rGZxwwy5b18c/j637YAWyi+s6gygLukC9alYNL8lgbO5bzaIWoH8GzoHy1p/55bhgX1/3bpyJROcsdWv08UuZy8nzvHUET5kS/OxtLFOte+oxMprt7+WIfDpQG1kQ1m/2L9JXylk79rIGFztcJPwqf5nM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=POByZYHa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="POByZYHa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 357E1C2BD10; Tue, 14 May 2024 11:42:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1715686972; bh=m6GW91DfAd6C1rwRR5bhu3roPuG5SRU2n6kzhuhPPhI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=POByZYHaU8429XnMauYVjbxcUuWNbWbbFjYRaSjzENKMXVEroF5+9OErLdBOQxs7q lNsAf/PDO0HsTIPjzcj6oPAzqz9LX7CIIXNOZvwOMs5CUcwrtarhR4/Ea7pqJZR7pX iv41FEX68qbTpx7GlP03Gxqnh8CPYxpU8NqQHtbI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Heiko Carstens , Claudio Imbrenda , Alexander Gordeev , Sasha Levin Subject: [PATCH 5.4 21/84] s390/mm: Fix clearing storage keys for huge pages Date: Tue, 14 May 2024 12:19:32 +0200 Message-ID: <20240514100952.492146316@linuxfoundation.org> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240514100951.686412426@linuxfoundation.org> References: <20240514100951.686412426@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Claudio Imbrenda [ Upstream commit 412050af2ea39407fe43324b0be4ab641530ce88 ] The function __storage_key_init_range() expects the end address to be the first byte outside the range to be initialized. I.e. end - start should be the size of the area to be initialized. The current code works because __storage_key_init_range() will still loop over every page in the range, but it is slower than using sske_frame(). Fixes: 3afdfca69870 ("s390/mm: Clear skeys for newly mapped huge guest pmds") Reviewed-by: Heiko Carstens Signed-off-by: Claudio Imbrenda Link: https://lore.kernel.org/r/20240416114220.28489-3-imbrenda@linux.ibm.com Signed-off-by: Alexander Gordeev Signed-off-by: Sasha Levin --- arch/s390/mm/hugetlbpage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/mm/hugetlbpage.c b/arch/s390/mm/hugetlbpage.c index ff8234bca56cd..6b688e3498c01 100644 --- a/arch/s390/mm/hugetlbpage.c +++ b/arch/s390/mm/hugetlbpage.c @@ -146,7 +146,7 @@ static void clear_huge_pte_skeys(struct mm_struct *mm, unsigned long rste) } if (!test_and_set_bit(PG_arch_1, &page->flags)) - __storage_key_init_range(paddr, paddr + size - 1); + __storage_key_init_range(paddr, paddr + size); } void set_huge_pte_at(struct mm_struct *mm, unsigned long addr, -- 2.43.0