[PATCH 5.4 82/84] pinctrl: mediatek: Fix some off by one bugs

Greg Kroah-Hartman
2024-05-14T11:45:52Z

From: Dan Carpenter <dan.carpenter@oracle.com>

commit 3385ab72d995fc0b876818a36203bf2429445686 upstream.

These comparisons should be >= instead of > to prevent accessing one
element beyond the end of the hw->soc->pins[] array.

Fixes: 3de7deefce69 ("pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()")
Fixes: 184d8e13f9b1 ("pinctrl: mediatek: Add support for pin configuration dump via debugfs.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200218055247.74s2xa7veqx2do34@kili.mountain
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/pinctrl/mediatek/pinctrl-paris.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

--- a/drivers/pinctrl/mediatek/pinctrl-paris.c
+++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
@@ -610,7 +610,7 @@ static int mtk_gpio_get_direction(struct
const struct mtk_pin_desc *desc;
int value, err;

- if (gpio > hw->soc->npins)
+ if (gpio >= hw->soc->npins)
return -EINVAL;

desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio];
@@ -628,7 +628,7 @@ static int mtk_gpio_get(struct gpio_chip
const struct mtk_pin_desc *desc;
int value, err;

- if (gpio > hw->soc->npins)
+ if (gpio >= hw->soc->npins)
return -EINVAL;

desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio];
@@ -645,7 +645,7 @@ static void mtk_gpio_set(struct gpio_chi
struct mtk_pinctrl *hw = gpiochip_get_data(chip);
const struct mtk_pin_desc *desc;

- if (gpio > hw->soc->npins)
+ if (gpio >= hw->soc->npins)
return;

desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio];
@@ -657,7 +657,7 @@ static int mtk_gpio_direction_input(stru
{
struct mtk_pinctrl *hw = gpiochip_get_data(chip);

- if (gpio > hw->soc->npins)
+ if (gpio >= hw->soc->npins)
return -EINVAL;

return pinctrl_gpio_direction_input(chip->base + gpio);
@@ -668,7 +668,7 @@ static int mtk_gpio_direction_output(str
{
struct mtk_pinctrl *hw = gpiochip_get_data(chip);

- if (gpio > hw->soc->npins)
+ if (gpio >= hw->soc->npins)
return -EINVAL;

mtk_gpio_set(chip, gpio, value);