From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96FB61E495; Tue, 14 May 2024 11:44:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715687082; cv=none; b=AcpCT4U9d50m+WXjyZ0lYMLlZltfZfkhAuVDrVNlcrzrGHQ3rgxvi/EYoomomlzmzhp4bE2fxnGIzfxQ6Mf/5pHOYns7EZv8PLOL+Vygei8MeaYW4aKBBQAhSuqhm6moOjJLvZoQEhL7l1W/qw+YxlJDPlts14+ZIWRcHeG2UAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715687082; c=relaxed/simple; bh=4sWCrvOdUCUxbKephh03GXjfuYq78/gm3GQ9XYsoufY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OFt8jS+znJP+4obXOF+tPd4KS2duIKukr/wR+Yl8Cr+4GZXMDmPKaeSLvp7CyiP5wfuO3R8ML05dOVEezd3La0f6dv/KzMsqj74IoeZbbChKHxTsVVS+qakKNEjGGV2hUTUXumlf4AsSa7w6mG11Z2J2MmNutM44iSscKd71vC0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NmJdNlFC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NmJdNlFC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 19AAFC2BD10; Tue, 14 May 2024 11:44:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1715687082; bh=4sWCrvOdUCUxbKephh03GXjfuYq78/gm3GQ9XYsoufY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NmJdNlFCzOH5tVMkdzQuO7WuAo6O8AXKekKIGkt1AiqC+eNvyyKdcfjuwCxs5WdXM nbdz/7FHqclmYCw0W2GFBgdEyM1o0s5rrfwvE2iZarr9CZ7V92E9tdTyMTQ13Nze+b pq2mQIorexx12cRFOK1Xau6F+IlR8IPoH8yytNNo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Paolo Abeni , Xin Long , Simon Horman , Tung Nguyen , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.4 31/84] tipc: fix a possible memleak in tipc_buf_append Date: Tue, 14 May 2024 12:19:42 +0200 Message-ID: <20240514100952.866317402@linuxfoundation.org> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240514100951.686412426@linuxfoundation.org> References: <20240514100951.686412426@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Xin Long [ Upstream commit 97bf6f81b29a8efaf5d0983251a7450e5794370d ] __skb_linearize() doesn't free the skb when it fails, so move '*buf = NULL' after __skb_linearize(), so that the skb can be freed on the err path. Fixes: b7df21cf1b79 ("tipc: skb_linearize the head skb when reassembling msgs") Reported-by: Paolo Abeni Signed-off-by: Xin Long Reviewed-by: Simon Horman Reviewed-by: Tung Nguyen Link: https://lore.kernel.org/r/90710748c29a1521efac4f75ea01b3b7e61414cf.1714485818.git.lucien.xin@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/tipc/msg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/msg.c b/net/tipc/msg.c index e4ea942873d49..c04fcf71d74d6 100644 --- a/net/tipc/msg.c +++ b/net/tipc/msg.c @@ -140,9 +140,9 @@ int tipc_buf_append(struct sk_buff **headbuf, struct sk_buff **buf) if (fragid == FIRST_FRAGMENT) { if (unlikely(head)) goto err; - *buf = NULL; if (skb_has_frag_list(frag) && __skb_linearize(frag)) goto err; + *buf = NULL; frag = skb_unshare(frag, GFP_ATOMIC); if (unlikely(!frag)) goto err; -- 2.43.0