From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46DCC1E495; Tue, 14 May 2024 11:44:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715687091; cv=none; b=lEQKG2APsYm1M2LCk7xITwfP1uLimL62meDW4GB5wbrpyxlXc3LKlRk+H1FVlpRLXgcULUf3eVUHAuVTQmkOovQl8ZdZt9hZzEVDdreQDCSBB53q2/U09/Rx42Lx3MqyMYYvfmT9T4IKypiyW0cpWz6ZKxAdh37dSBM1TgvaQgw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715687091; c=relaxed/simple; bh=uRk9EEati40Q7usAr5kw2CKNM/lT3LuGlM2HrTXJkhg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BmbpPrcoYKl9qeK1mJSzGO1b8ThrgKsNVaVDlaa7nenvl5eAH0nzBLdjo7QhjEsNKUyshTfq8cDMmPqCtE2U+75ciOVdRcy7ov74ktcP0lMoj874FOSvbyjjwqBY14ITU4nSV3/GcG5rrJUb/iU0mssD7bpV7UMqKJtHJLlA5PQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=vo8PafTn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="vo8PafTn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B65AEC2BD10; Tue, 14 May 2024 11:44:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1715687091; bh=uRk9EEati40Q7usAr5kw2CKNM/lT3LuGlM2HrTXJkhg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vo8PafTncOUW9kV5kWfBRIbPPET+FeLkqQV9KSJRfqNEYRmUida3cm+bUjbM+O91X OuoyzecaGl48CBYz+Pz7I4R5kC7HqHfU3FZd7WPEdkjJegCAwWfvxnKpGhCnawn+j7 DaIU+1puTh3TVPkOnUu+BuT64j3lLy4L4AQhgSgc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dmitry Shmidt , Neil Armstrong , Jerome Brunet , Mark Brown , Sasha Levin Subject: [PATCH 5.4 60/84] ASoC: meson: axg-card: Fix nonatomic links Date: Tue, 14 May 2024 12:20:11 +0200 Message-ID: <20240514100953.944523265@linuxfoundation.org> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240514100951.686412426@linuxfoundation.org> References: <20240514100951.686412426@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Neil Armstrong [ Upstream commit 0c9b152c72e53016e96593bdbb8cffe2176694b9 ] This commit e138233e56e9829e65b6293887063a1a3ccb2d68 causes the following system crash when using audio on G12A/G12B & SM1 systems: BUG: sleeping function called from invalid context at kernel/locking/mutex.c:282 in_atomic(): 1, irqs_disabled(): 128, non_block: 0, pid: 0, name: swapper/0 preempt_count: 10001, expected: 0 RCU nest depth: 0, expected: 0 Preemption disabled at: schedule_preempt_disabled+0x20/0x2c mutex_lock+0x24/0x60 _snd_pcm_stream_lock_irqsave+0x20/0x3c snd_pcm_period_elapsed+0x24/0xa4 axg_fifo_pcm_irq_block+0x64/0xdc __handle_irq_event_percpu+0x104/0x264 handle_irq_event+0x48/0xb4 ... start_kernel+0x3f0/0x484 __primary_switched+0xc0/0xc8 Revert this commit until the crash is fixed. Fixes: e138233e56e9829e65b6 ("ASoC: meson: axg-card: make links nonatomic") Reported-by: Dmitry Shmidt Signed-off-by: Neil Armstrong Acked-by: Jerome Brunet Link: https://lore.kernel.org/r/20220421155725.2589089-2-narmstrong@baylibre.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/meson/axg-card.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/meson/axg-card.c b/sound/soc/meson/axg-card.c index 36a004192b562..7126344017fa6 100644 --- a/sound/soc/meson/axg-card.c +++ b/sound/soc/meson/axg-card.c @@ -568,7 +568,6 @@ static int axg_card_add_link(struct snd_soc_card *card, struct device_node *np, dai_link->cpus = cpu; dai_link->num_cpus = 1; - dai_link->nonatomic = true; ret = axg_card_parse_dai(card, np, &dai_link->cpus->of_node, &dai_link->cpus->dai_name); -- 2.43.0