From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14B87126F02; Tue, 14 May 2024 11:47:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715687268; cv=none; b=cOHSVKL3h3sf1r2f1dGWXSBT1AemOLDq+7PT6VGud4FAd1VXqor42X/M+mTormRI1xukRNu4RWX8vI6ccWGQJIp/wm+Gt2nvEoAGeLp/KeNJ9hEVo4TUZ8bZ20SKUe9qv2AaYosjr+7EYtFRsffFUepB4cETBw5ZtLgDXiJkr1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715687268; c=relaxed/simple; bh=287nP//lWFtJiMPNqeKof84cry/LZV6pZXvhlodR1dI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PSIjDIq6vAaROfQ6nfSw6uC9WEKD+JYVd39B6jxd4ysQ2sLC+cr5Xlb9fdg8GSRM4vYUW5ooPcDUXPnNdi9Hj6MhZziXtyCJXJ9h0Gj5GFVHy8fNuYEXNLaX3WMTi/B2LNu9VKFL96e+BuAMZp1+6E69GL+Ib0CHDXZwDYBtOGk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=KAGSklod; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="KAGSklod" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F0C2C2BD10; Tue, 14 May 2024 11:47:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1715687268; bh=287nP//lWFtJiMPNqeKof84cry/LZV6pZXvhlodR1dI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KAGSklodYpKSYOcQ1LeABwKELlrrDHuT7p7tQOxzEX1YCUa8cAHJQuBA8DY/NgztG sjwsPzGco+p2WSxX0eFkxqKm7oH83zHcar0Jiy9RSKpB7b/Zn495CKt6KDg0a8zTGQ 56Xm406QVVxOLMR3OCWxAt46WjKyDf8sYj8qVXKo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Felix Fietkau , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 038/111] net: core: reject skb_copy(_expand) for fraglist GSO skbs Date: Tue, 14 May 2024 12:19:36 +0200 Message-ID: <20240514100958.574717233@linuxfoundation.org> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240514100957.114746054@linuxfoundation.org> References: <20240514100957.114746054@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Felix Fietkau [ Upstream commit d091e579b864fa790dd6a0cd537a22c383126681 ] SKB_GSO_FRAGLIST skbs must not be linearized, otherwise they become invalid. Return NULL if such an skb is passed to skb_copy or skb_copy_expand, in order to prevent a crash on a potential later call to skb_gso_segment. Fixes: 3a1296a38d0c ("net: Support GRO/GSO fraglist chaining.") Signed-off-by: Felix Fietkau Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- net/core/skbuff.c | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 50261f3aec82b..fd53b66f2ca1d 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -1516,11 +1516,17 @@ static inline int skb_alloc_rx_flag(const struct sk_buff *skb) struct sk_buff *skb_copy(const struct sk_buff *skb, gfp_t gfp_mask) { - int headerlen = skb_headroom(skb); - unsigned int size = skb_end_offset(skb) + skb->data_len; - struct sk_buff *n = __alloc_skb(size, gfp_mask, - skb_alloc_rx_flag(skb), NUMA_NO_NODE); + struct sk_buff *n; + unsigned int size; + int headerlen; + + if (WARN_ON_ONCE(skb_shinfo(skb)->gso_type & SKB_GSO_FRAGLIST)) + return NULL; + headerlen = skb_headroom(skb); + size = skb_end_offset(skb) + skb->data_len; + n = __alloc_skb(size, gfp_mask, + skb_alloc_rx_flag(skb), NUMA_NO_NODE); if (!n) return NULL; @@ -1750,12 +1756,17 @@ struct sk_buff *skb_copy_expand(const struct sk_buff *skb, /* * Allocate the copy buffer */ - struct sk_buff *n = __alloc_skb(newheadroom + skb->len + newtailroom, - gfp_mask, skb_alloc_rx_flag(skb), - NUMA_NO_NODE); - int oldheadroom = skb_headroom(skb); int head_copy_len, head_copy_off; + struct sk_buff *n; + int oldheadroom; + + if (WARN_ON_ONCE(skb_shinfo(skb)->gso_type & SKB_GSO_FRAGLIST)) + return NULL; + oldheadroom = skb_headroom(skb); + n = __alloc_skb(newheadroom + skb->len + newtailroom, + gfp_mask, skb_alloc_rx_flag(skb), + NUMA_NO_NODE); if (!n) return NULL; -- 2.43.0