From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12B1683CD9; Tue, 14 May 2024 11:48:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715687291; cv=none; b=rdXB9xr28GVegArVjLn9WwsVM5+p6MtMoytiQcBWIn1/b4xU6/9ilUGCQhWJlE4NKCWaTFZcNLv75rO7loWJRkuqPqlwv3/ipGrEnyZLc8O4K1UlF8LNPnlde+s/rFF6DLbN1IHRyAEXsBo2KeXO5X+7Q7xT3d/tAbSs39JM5as= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715687291; c=relaxed/simple; bh=fX7ao7X9RQb0ofw6jrUlScZRwl12BdQq6VVd299YjRU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mJ/JGjXquGO5eYuZ7RfraipqBxvxaFY6z1W/P48vtISttyh1fkbcTc+MR1osWAmKqX18QAXoqAUb55YRVbf1tlaqsw6bPb4cXFlulRK+vz4Fl6CabE/66nQIhhQ+ER3trCTg2LP6umS2hC55hz6iRgrQAUAPnV79miFSwvjFlvs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=i2axUXW0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="i2axUXW0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FCF9C2BD10; Tue, 14 May 2024 11:48:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1715687291; bh=fX7ao7X9RQb0ofw6jrUlScZRwl12BdQq6VVd299YjRU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i2axUXW0usXtZu76rQgIgdkcIk+ULOKTkYfuR/apzl1veJWTCgnYi0uB6wGvtrcTy E4TlAd5hSQgC6xgnfwbrtp+mfvCKQDAS/REThYEUkuUpJelpJ388eJI0QGzr7587Ed lAAPcYzDeP7RXiwqxdSYMa+uB8c9sVxU8gXScl/0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Andrew Price , Andreas Gruenbacher , Sasha Levin Subject: [PATCH 5.10 045/111] gfs2: Fix invalid metadata access in punch_hole Date: Tue, 14 May 2024 12:19:43 +0200 Message-ID: <20240514100958.846734629@linuxfoundation.org> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240514100957.114746054@linuxfoundation.org> References: <20240514100957.114746054@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andrew Price [ Upstream commit c95346ac918c5badf51b9a7ac58a26d3bd5bb224 ] In punch_hole(), when the offset lies in the final block for a given height, there is no hole to punch, but the maximum size check fails to detect that. Consequently, punch_hole() will try to punch a hole beyond the end of the metadata and fail. Fix the maximum size check. Signed-off-by: Andrew Price Signed-off-by: Andreas Gruenbacher Signed-off-by: Sasha Levin --- fs/gfs2/bmap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/bmap.c b/fs/gfs2/bmap.c index eaee95d2ad143..3d60ad9982c87 100644 --- a/fs/gfs2/bmap.c +++ b/fs/gfs2/bmap.c @@ -1758,7 +1758,8 @@ static int punch_hole(struct gfs2_inode *ip, u64 offset, u64 length) struct buffer_head *dibh, *bh; struct gfs2_holder rd_gh; unsigned int bsize_shift = sdp->sd_sb.sb_bsize_shift; - u64 lblock = (offset + (1 << bsize_shift) - 1) >> bsize_shift; + unsigned int bsize = 1 << bsize_shift; + u64 lblock = (offset + bsize - 1) >> bsize_shift; __u16 start_list[GFS2_MAX_META_HEIGHT]; __u16 __end_list[GFS2_MAX_META_HEIGHT], *end_list = NULL; unsigned int start_aligned, end_aligned; @@ -1769,7 +1770,7 @@ static int punch_hole(struct gfs2_inode *ip, u64 offset, u64 length) u64 prev_bnr = 0; __be64 *start, *end; - if (offset >= maxsize) { + if (offset + bsize - 1 >= maxsize) { /* * The starting point lies beyond the allocated meta-data; * there are no blocks do deallocate. -- 2.43.0