From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B98266B5E; Tue, 14 May 2024 11:50:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715687403; cv=none; b=ltFh12k2S51IE1vxFkymccWIGECJz1Pj2SC9EU0ggix5/YGaT+8K0hWuBbJAOmiSwLztNmJOvcsQyF4csjZLxgNGo1qG6oGkT5JQ70SMB1bI2gLtMtpKuXsetaDHucPQy0Y1VFCY4nEHof7mmovV8RClGnikT4XFE1DDQiqdLXE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715687403; c=relaxed/simple; bh=4NiFA5iYhx917NnDre4gTckDvFML6mlt6uE+zRO97mo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sB4dYkLsVgUqsd5kCDpQnEOz+7R/wVI/gwU2WyTfWdB4wizGbJP2CYZz9ozEDGdLvFHYRpF0aUuNdBjgNFTrieck3EDpoLGjLcpTfo85vlVM2erVzDMmMxdOBeex09uN4Onbl5VMxqwaIaSH88Ugf5QwG2j6aypOwPUB63E6jlM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=L4o9GLfg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="L4o9GLfg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25258C2BD10; Tue, 14 May 2024 11:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1715687403; bh=4NiFA5iYhx917NnDre4gTckDvFML6mlt6uE+zRO97mo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L4o9GLfgQyq3lGWOpZA+svzHrr9VAiFiLL3p/loYTVcpV+d9mnEADKzJ9iVbyFEZh 0EXYxdCV2nniDzM8Xeo7caTvd6A+Iy87vVS2dBBOcATLEmNLBvSVrTwcsxLXQsWrJ4 z0hyOMswlGO84neACGto9qLCc2zDrkYIGERdZ0BE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Qu Wenruo , Boris Burkov , David Sterba , Sasha Levin Subject: [PATCH 5.10 057/111] btrfs: make btrfs_clear_delalloc_extent() free delalloc reserve Date: Tue, 14 May 2024 12:19:55 +0200 Message-ID: <20240514100959.300482845@linuxfoundation.org> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240514100957.114746054@linuxfoundation.org> References: <20240514100957.114746054@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Boris Burkov [ Upstream commit 3c6f0c5ecc8910d4ffb0dfe85609ebc0c91c8f34 ] Currently, this call site in btrfs_clear_delalloc_extent() only converts the reservation. We are marking it not delalloc, so I don't think it makes sense to keep the rsv around. This is a path where we are not sure to join a transaction, so it leads to incorrect free-ing during umount. Helps with the pass rate of generic/269 and generic/475. Reviewed-by: Qu Wenruo Signed-off-by: Boris Burkov Signed-off-by: David Sterba Signed-off-by: Sasha Levin --- fs/btrfs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 591caac2bf814..1f99d7dced17a 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -2070,7 +2070,7 @@ void btrfs_clear_delalloc_extent(struct inode *vfs_inode, */ if (*bits & EXTENT_CLEAR_META_RESV && root != fs_info->tree_root) - btrfs_delalloc_release_metadata(inode, len, false); + btrfs_delalloc_release_metadata(inode, len, true); /* For sanity tests. */ if (btrfs_is_testing(fs_info)) -- 2.43.0