From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A985B3BBF2; Tue, 14 May 2024 11:51:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715687462; cv=none; b=pt70K942DjLlZLGZEOqEKa47n3+YFFGCR0eKwM2OTf30aJUw4lxdOuE+Kr8rq3QTZuNSSSZhgjGJ5NPd9mzYlIDlIYErBI3MSE10jm9gSLAq0Up2A1O7RHnlMVVFuA8wLR2KGhwER4F+M2FcQ0JSf64RLV5ftOHALBe44esoXqU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715687462; c=relaxed/simple; bh=h40OJugkW28zTgkCX0biT+hh0rfq0eThXO8KPYc5CPU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oP40HPLqfY3W0a6SlcBa0Lfx56b14APbJUFhv/qxyhjT3+KpZxDKFseNi0Yw4ftnhMxrMZEE9DBLeS0LrEPrTc2zAG26c4/c91IFNLkg2UnyU8qSg2AIjmv6DGG0dbxf/hdj3plwiacmfN+kDxIt9BKnI7XfQHHbqeNW+MDlOdw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=KMPyQuZ9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="KMPyQuZ9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F4EEC2BD10; Tue, 14 May 2024 11:51:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1715687462; bh=h40OJugkW28zTgkCX0biT+hh0rfq0eThXO8KPYc5CPU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KMPyQuZ91Q0/PWe1h3M96XeWfKtAEe5yJ99Ouk98k5E+7RRzBeaDeQphyhwrFWbBd VgSZMrNXdvueeu5W/4UmiAADYi78VK+sX+uy56Ln5RQZiwev/4CnYCgn06/Vu4SFct IdejwLAXEs/TCpOy0+UB1VLlUdJvB8XX4qx73Jaw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sameer Pujar , Thierry Reding , Mark Brown Subject: [PATCH 5.10 105/111] ASoC: tegra: Fix DSPK 16-bit playback Date: Tue, 14 May 2024 12:20:43 +0200 Message-ID: <20240514101001.122931236@linuxfoundation.org> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240514100957.114746054@linuxfoundation.org> References: <20240514100957.114746054@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sameer Pujar commit 2e93a29b48a017c777d4fcbfcc51aba4e6a90d38 upstream. DSPK configuration is wrong for 16-bit playback and this happens because the client config is always fixed at 24-bit in hw_params(). Fix this by updating the client config to 16-bit for the respective playback. Fixes: 327ef6470266 ("ASoC: tegra: Add Tegra186 based DSPK driver") Cc: stable@vger.kernel.org Signed-off-by: Sameer Pujar Acked-by: Thierry Reding Link: https://msgid.link/r/20240405104306.551036-1-spujar@nvidia.com Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/tegra/tegra186_dspk.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) --- a/sound/soc/tegra/tegra186_dspk.c +++ b/sound/soc/tegra/tegra186_dspk.c @@ -1,8 +1,7 @@ // SPDX-License-Identifier: GPL-2.0-only +// SPDX-FileCopyrightText: Copyright (c) 2020-2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved. // // tegra186_dspk.c - Tegra186 DSPK driver -// -// Copyright (c) 2020 NVIDIA CORPORATION. All rights reserved. #include #include @@ -241,14 +240,14 @@ static int tegra186_dspk_hw_params(struc return -EINVAL; } - cif_conf.client_bits = TEGRA_ACIF_BITS_24; - switch (params_format(params)) { case SNDRV_PCM_FORMAT_S16_LE: cif_conf.audio_bits = TEGRA_ACIF_BITS_16; + cif_conf.client_bits = TEGRA_ACIF_BITS_16; break; case SNDRV_PCM_FORMAT_S32_LE: cif_conf.audio_bits = TEGRA_ACIF_BITS_32; + cif_conf.client_bits = TEGRA_ACIF_BITS_24; break; default: dev_err(dev, "unsupported format!\n");