From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F8B1134CDC; Tue, 14 May 2024 11:30:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715686200; cv=none; b=jn3KiRgO7MgXUt1dkNMQCrdNd7f4cN1KS13WgB8ms8TeMSWDawe6/Z7GxkgIQ5oFgXdhjKMgL2pAg2XXUO/oMDbtxroweAE6rwnw4z2NWuDrOt4u65ex5bfW4cZSRmJlnGRf0kFxLKnFG2kq6YeGS/47jtogFcOWcoRo2VF3wzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715686200; c=relaxed/simple; bh=FMjwouewzDutFMlMKTq7RvjVRENFCtR2429yMJUUA4E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lcC1aMpLj95Zl3jE51cBxXSK2gZfyi1K5n8TZ0uPK76p5jtgYm7djrD2cVJOwTtPIPDzQSzt60cRBAC2TtN4SBNQzQi+7vj3kgBQR3PZJ6fGIjIQJiBT7EcuNAjGgPMefKC37D9zImg+HLnRLOGB44m2ioG3tvaEu1gNm70sEBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2XL5/uAs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2XL5/uAs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D428C2BD10; Tue, 14 May 2024 11:29:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1715686199; bh=FMjwouewzDutFMlMKTq7RvjVRENFCtR2429yMJUUA4E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2XL5/uAs7Szeb2/buM96jZ3kQGrHHN5RQx+dC4gHJpsbk32Kj7/+K5emNVeMrBWNP vNY+sei7q8KxZMue+dZ04QTiaHQ53Tpw1z7lRtUeDpT+IOj2wle2JFuZxOyo+A+DlS UQAmkAnfILLPrfASbrqOlCF4BVjUBvOtsCmtSyN0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Heiko Carstens , Claudio Imbrenda , Alexander Gordeev , Sasha Levin Subject: [PATCH 6.1 056/236] s390/mm: Fix clearing storage keys for huge pages Date: Tue, 14 May 2024 12:16:58 +0200 Message-ID: <20240514101022.475090888@linuxfoundation.org> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240514101020.320785513@linuxfoundation.org> References: <20240514101020.320785513@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Claudio Imbrenda [ Upstream commit 412050af2ea39407fe43324b0be4ab641530ce88 ] The function __storage_key_init_range() expects the end address to be the first byte outside the range to be initialized. I.e. end - start should be the size of the area to be initialized. The current code works because __storage_key_init_range() will still loop over every page in the range, but it is slower than using sske_frame(). Fixes: 3afdfca69870 ("s390/mm: Clear skeys for newly mapped huge guest pmds") Reviewed-by: Heiko Carstens Signed-off-by: Claudio Imbrenda Link: https://lore.kernel.org/r/20240416114220.28489-3-imbrenda@linux.ibm.com Signed-off-by: Alexander Gordeev Signed-off-by: Sasha Levin --- arch/s390/mm/hugetlbpage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/mm/hugetlbpage.c b/arch/s390/mm/hugetlbpage.c index c299a18273ffe..33ef6790114ab 100644 --- a/arch/s390/mm/hugetlbpage.c +++ b/arch/s390/mm/hugetlbpage.c @@ -139,7 +139,7 @@ static void clear_huge_pte_skeys(struct mm_struct *mm, unsigned long rste) } if (!test_and_set_bit(PG_arch_1, &page->flags)) - __storage_key_init_range(paddr, paddr + size - 1); + __storage_key_init_range(paddr, paddr + size); } void set_huge_pte_at(struct mm_struct *mm, unsigned long addr, -- 2.43.0