From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C17322094; Tue, 14 May 2024 11:33:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715686390; cv=none; b=opcrFMpGJyZvM/ViXbWEGqLu6lh2lErvjdoulL0XENuMqIgEuz4nXxZZWFU8Qn7skuYFM5/JxcnY6iBk2dq9ja5cXi+WSO6SW3ssrS1PpInehCBnZ/ZuoQfODFrfx/iCq5VrsnWHWVJGC+dY33nmDhRHb0B+Bzc7gTzfPWo0i3o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715686390; c=relaxed/simple; bh=NHUMD1wqcmtk+BChXI+SLVNiTt0VUUm8DfRGVIlzG0g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Kn86mrJ6wET5qkkE7TMkVOJHJ7acvqTMG7KDYCA3VvjZHuZU4ombXJUuixal4HRTY23naWOf0Gq26EIb8qyW+pw5HMIT7yAQcjQHdSD5OnK8coyKxgrCfvcNyYSYqbMH4Va8+hGONLaSyIAAePhkysBEVOOeu/6ss7YizP7Wi28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=X5A0iFpK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="X5A0iFpK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7293C2BD10; Tue, 14 May 2024 11:33:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1715686390; bh=NHUMD1wqcmtk+BChXI+SLVNiTt0VUUm8DfRGVIlzG0g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X5A0iFpKwIIyBlIoHedt/sLu/lNA0VdiGwC98M5tVEEr/NwI6a9d8M5Sg2ukQQcMB orVM7myg3UCzwJl0XK8b52R2oi9yAyFYBAaXJyqg0J02dCeKz3EtD3lX+k94voTNfP Ru2sWJF6gDPfIXEm6OBbqbqm5u0hDYn4D+qdhmRI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jon Hunter , Thierry Reding , Sasha Levin Subject: [PATCH 6.1 122/236] gpu: host1x: Do not setup DMA for virtual devices Date: Tue, 14 May 2024 12:18:04 +0200 Message-ID: <20240514101025.002818882@linuxfoundation.org> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240514101020.320785513@linuxfoundation.org> References: <20240514101020.320785513@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thierry Reding [ Upstream commit 8ab58f6841b19423231c5db3378691ec80c778f8 ] The host1x devices are virtual compound devices and do not perform DMA accesses themselves, so they do not need to be set up for DMA. Ideally we would also not need to set up DMA masks for the virtual devices, but we currently still need those for legacy support on old hardware. Tested-by: Jon Hunter Acked-by: Jon Hunter Signed-off-by: Thierry Reding Link: https://patchwork.freedesktop.org/patch/msgid/20240314154943.2487549-1-thierry.reding@gmail.com Signed-off-by: Sasha Levin --- drivers/gpu/host1x/bus.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/host1x/bus.c b/drivers/gpu/host1x/bus.c index bdee16a0bb8e2..ba622fb5e4822 100644 --- a/drivers/gpu/host1x/bus.c +++ b/drivers/gpu/host1x/bus.c @@ -368,11 +368,6 @@ static int host1x_device_uevent(struct device *dev, return 0; } -static int host1x_dma_configure(struct device *dev) -{ - return of_dma_configure(dev, dev->of_node, true); -} - static const struct dev_pm_ops host1x_device_pm_ops = { .suspend = pm_generic_suspend, .resume = pm_generic_resume, @@ -386,7 +381,6 @@ struct bus_type host1x_bus_type = { .name = "host1x", .match = host1x_device_match, .uevent = host1x_device_uevent, - .dma_configure = host1x_dma_configure, .pm = &host1x_device_pm_ops, }; @@ -475,8 +469,6 @@ static int host1x_device_add(struct host1x *host1x, device->dev.bus = &host1x_bus_type; device->dev.parent = host1x->dev; - of_dma_configure(&device->dev, host1x->dev->of_node, true); - device->dev.dma_parms = &device->dma_parms; dma_set_max_seg_size(&device->dev, UINT_MAX); -- 2.43.0