From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64FC154903; Tue, 14 May 2024 11:05:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715684744; cv=none; b=i9GyjhItbbi8T9mdI8d/wY5XsLypCKARpuspesNcS8xAcFalzJSgghXnEo+KJcovMnb0xToa8xrEifHPLL2mVh6iD9TFsLsf4eOjE82/9GpPRjxsOhDO2H1ZSdVPO/tLxpipZ2YAd3fAzHG4psLKM/a2WWnblr8vHLlQDHoVPCY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715684744; c=relaxed/simple; bh=GOeRE61lMrYy3XU2ucnzIkIGrWpkLdEu+p978oGaWVE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eOCmlG7y6zM5fRpujsL8B1CenF/aqZMkF0H2w0NLbqG8d5gOstQZacLgrOFw6y2p2td/M/MQpTBs0SuOpE80nAqbgH9qlWL4L3tQQDRNy0aQo42azEOC3Bf5yJTDDYtLNGXQ6lE7lWrmpBtXFYgHQRR32qPi/jxeKQk93nTgNaY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=b3VMHKMk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="b3VMHKMk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C53D6C2BD10; Tue, 14 May 2024 11:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1715684744; bh=GOeRE61lMrYy3XU2ucnzIkIGrWpkLdEu+p978oGaWVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b3VMHKMkwD85znrT1KRL/48FnPQ7ScJSYmBhHBVa2omdsneIU1/lVp3crCjtU4vx6 IIoOMBL+ttAUgNUJnlhM2agaoTUIMhYUp3iPxrFANfSOp6dIJDnwSnnYiHGDrJ7hax ojypdBjsdddoShY9VFFY8DoXf1f6miJSHwebMnMc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Andy Shevchenko , Dmitry Baryshkov , Neil Armstrong , Sui Jingfeng , Sasha Levin Subject: [PATCH 6.6 083/301] drm/panel: ili9341: Respect deferred probe Date: Tue, 14 May 2024 12:15:54 +0200 Message-ID: <20240514101035.381694626@linuxfoundation.org> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20240514101032.219857983@linuxfoundation.org> References: <20240514101032.219857983@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Andy Shevchenko [ Upstream commit 740fc1e0509be3f7e2207e89125b06119ed62943 ] GPIO controller might not be available when driver is being probed. There are plenty of reasons why, one of which is deferred probe. Since GPIOs are optional, return any error code we got to the upper layer, including deferred probe. With that in mind, use dev_err_probe() in order to avoid spamming the logs. Fixes: 5a04227326b0 ("drm/panel: Add ilitek ili9341 panel driver") Signed-off-by: Andy Shevchenko Reviewed-by: Dmitry Baryshkov Reviewed-by: Neil Armstrong Reviewed-by: Sui Jingfeng Link: https://lore.kernel.org/r/20240425142706.2440113-3-andriy.shevchenko@linux.intel.com Signed-off-by: Neil Armstrong Link: https://patchwork.freedesktop.org/patch/msgid/20240425142706.2440113-3-andriy.shevchenko@linux.intel.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c index 7584ddb0e4416..24c74c56e5648 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c @@ -715,11 +715,11 @@ static int ili9341_probe(struct spi_device *spi) reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(reset)) - dev_err(dev, "Failed to get gpio 'reset'\n"); + return dev_err_probe(dev, PTR_ERR(reset), "Failed to get gpio 'reset'\n"); dc = devm_gpiod_get_optional(dev, "dc", GPIOD_OUT_LOW); if (IS_ERR(dc)) - dev_err(dev, "Failed to get gpio 'dc'\n"); + return dev_err_probe(dev, PTR_ERR(dc), "Failed to get gpio 'dc'\n"); if (!strcmp(id->name, "sf-tc240t-9370-t")) return ili9341_dpi_probe(spi, dc, reset); -- 2.43.0