Fix Intel's ice driver in stable

Fix Intel's ice driver in stable

[Ahmed Zaki]

Hello,

Upstream commit 11fbb1bfb5bc8c98b2d7db9da332b5e568f4aaab ("ice: use 
relative VSI index for VFs VSIs") was applied to stable 6.1, 6.6 and 6.8:

6.1: 5693dd6d3d01f0eea24401f815c98b64cb315b67
6.6: c926393dc3442c38fdcab17d040837cf4acad1c3
6.8: d3da0d4d9fb472ad7dccb784f3d9de40d0c2f6a9

However, it was a part of a series submitted to net-next [1]. Applying 
this one patch on its own broke the VF devices created with the ice as a PF:

   # [  307.688237] iavf: Intel(R) Ethernet Adaptive Virtual Function 
Network Driver
   # [  307.688241] Copyright (c) 2013 - 2018 Intel Corporation.
   # [  307.688424] iavf 0000:af:01.0: enabling device (0000 -> 0002)
   # [  307.758860] iavf 0000:af:01.0: Invalid MAC address 
00:00:00:00:00:00, using random
   # [  307.759628] iavf 0000:af:01.0: Multiqueue Enabled: Queue pair 
count = 16
   # [  307.759683] iavf 0000:af:01.0: MAC address: 6a:46:83:88:c2:26
   # [  307.759688] iavf 0000:af:01.0: GRO is enabled
   # [  307.790937] iavf 0000:af:01.0 ens802f0v0: renamed from eth0
   # [  307.896041] iavf 0000:af:01.0: PF returned error -5 
(IAVF_ERR_PARAM) to our request 6
   # [  307.916967] iavf 0000:af:01.0: PF returned error -5 
(IAVF_ERR_PARAM) to our request 8


The VF initialization fails and the VF device is completely unusable.

This can be fixed either by:
1 - Reverting the above mentioned commit (upstream 
11fbb1bfb5bc8c98b2d7db9da332b5e568f4aaab)

Or,

2 - applying the following upstream commits (part of the series):
  a) a21605993dd5dfd15edfa7f06705ede17b519026 ("ice: pass VSI pointer 
into ice_vc_isvalid_q_id")
  b) 363f689600dd010703ce6391bcfc729a97d21840 ("ice: remove unnecessary 
duplicate checks for VF VSI ID")


Thanks,
Ahmed

[1]: https://www.spinics.net/lists/netdev/msg979289.html

RE: Fix Intel's ice driver in stable

[Samudrala, Sridhar]

We need to fix this ASAP. Flipkart reported this issue with 6.1.x stable kernel.
Not sure why this commit was backported to LTS kernel as it is not a bug fix, but introduced as part of enabling live migration.

Thanks
Sridhar

-----Original Message-----
From: Zaki, Ahmed <ahmed.zaki@intel.com> 
Sent: Wednesday, May 15, 2024 2:17 PM
To: stable@vger.kernel.org
Cc: Keller, Jacob E <jacob.e.keller@intel.com>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Kitszel, Przemyslaw <przemyslaw.kitszel@intel.com>; Chittim, Madhu <madhu.chittim@intel.com>; Samudrala, Sridhar <sridhar.samudrala@intel.com>
Subject: Fix Intel's ice driver in stable

Hello,

Upstream commit 11fbb1bfb5bc8c98b2d7db9da332b5e568f4aaab ("ice: use 
relative VSI index for VFs VSIs") was applied to stable 6.1, 6.6 and 6.8:

6.1: 5693dd6d3d01f0eea24401f815c98b64cb315b67
6.6: c926393dc3442c38fdcab17d040837cf4acad1c3
6.8: d3da0d4d9fb472ad7dccb784f3d9de40d0c2f6a9

However, it was a part of a series submitted to net-next [1]. Applying 
this one patch on its own broke the VF devices created with the ice as a PF:

   # [  307.688237] iavf: Intel(R) Ethernet Adaptive Virtual Function 
Network Driver
   # [  307.688241] Copyright (c) 2013 - 2018 Intel Corporation.
   # [  307.688424] iavf 0000:af:01.0: enabling device (0000 -> 0002)
   # [  307.758860] iavf 0000:af:01.0: Invalid MAC address 
00:00:00:00:00:00, using random
   # [  307.759628] iavf 0000:af:01.0: Multiqueue Enabled: Queue pair 
count = 16
   # [  307.759683] iavf 0000:af:01.0: MAC address: 6a:46:83:88:c2:26
   # [  307.759688] iavf 0000:af:01.0: GRO is enabled
   # [  307.790937] iavf 0000:af:01.0 ens802f0v0: renamed from eth0
   # [  307.896041] iavf 0000:af:01.0: PF returned error -5 
(IAVF_ERR_PARAM) to our request 6
   # [  307.916967] iavf 0000:af:01.0: PF returned error -5 
(IAVF_ERR_PARAM) to our request 8


The VF initialization fails and the VF device is completely unusable.

This can be fixed either by:
1 - Reverting the above mentioned commit (upstream 
11fbb1bfb5bc8c98b2d7db9da332b5e568f4aaab)

Or,

2 - applying the following upstream commits (part of the series):
  a) a21605993dd5dfd15edfa7f06705ede17b519026 ("ice: pass VSI pointer 
into ice_vc_isvalid_q_id")
  b) 363f689600dd010703ce6391bcfc729a97d21840 ("ice: remove unnecessary 
duplicate checks for VF VSI ID")


Thanks,
Ahmed

[1]: https://www.spinics.net/lists/netdev/msg979289.html

Re: Fix Intel's ice driver in stable

[Greg KH]

On Thu, May 16, 2024 at 05:12:40AM +0000, Samudrala, Sridhar wrote:
> We need to fix this ASAP. Flipkart reported this issue with 6.1.x stable kernel.
> Not sure why this commit was backported to LTS kernel as it is not a bug fix, but introduced as part of enabling live migration.

Back in March you were notified this was going to be picked up for the
stable tree as part of the AUTOSEL work:
	https://lore.kernel.org/r/20240329122652.3082296-63-sashal@kernel.org

Any reason this wasn't noticed then?

thanks,

greg k-h

Re: Fix Intel's ice driver in stable

[Greg KH]

On Wed, May 15, 2024 at 03:16:39PM -0600, Ahmed Zaki wrote:
> Hello,
> 
> Upstream commit 11fbb1bfb5bc8c98b2d7db9da332b5e568f4aaab ("ice: use relative
> VSI index for VFs VSIs") was applied to stable 6.1, 6.6 and 6.8:
> 
> 6.1: 5693dd6d3d01f0eea24401f815c98b64cb315b67
> 6.6: c926393dc3442c38fdcab17d040837cf4acad1c3
> 6.8: d3da0d4d9fb472ad7dccb784f3d9de40d0c2f6a9
> 
> However, it was a part of a series submitted to net-next [1]. Applying this
> one patch on its own broke the VF devices created with the ice as a PF:
> 
>   # [  307.688237] iavf: Intel(R) Ethernet Adaptive Virtual Function Network
> Driver
>   # [  307.688241] Copyright (c) 2013 - 2018 Intel Corporation.
>   # [  307.688424] iavf 0000:af:01.0: enabling device (0000 -> 0002)
>   # [  307.758860] iavf 0000:af:01.0: Invalid MAC address 00:00:00:00:00:00,
> using random
>   # [  307.759628] iavf 0000:af:01.0: Multiqueue Enabled: Queue pair count =
> 16
>   # [  307.759683] iavf 0000:af:01.0: MAC address: 6a:46:83:88:c2:26
>   # [  307.759688] iavf 0000:af:01.0: GRO is enabled
>   # [  307.790937] iavf 0000:af:01.0 ens802f0v0: renamed from eth0
>   # [  307.896041] iavf 0000:af:01.0: PF returned error -5 (IAVF_ERR_PARAM)
> to our request 6
>   # [  307.916967] iavf 0000:af:01.0: PF returned error -5 (IAVF_ERR_PARAM)
> to our request 8
> 
> 
> The VF initialization fails and the VF device is completely unusable.
> 
> This can be fixed either by:
> 1 - Reverting the above mentioned commit (upstream
> 11fbb1bfb5bc8c98b2d7db9da332b5e568f4aaab)

If you want this reverted, can you send the revert?

> Or,
> 
> 2 - applying the following upstream commits (part of the series):
>  a) a21605993dd5dfd15edfa7f06705ede17b519026 ("ice: pass VSI pointer into
> ice_vc_isvalid_q_id")
>  b) 363f689600dd010703ce6391bcfc729a97d21840 ("ice: remove unnecessary
> duplicate checks for VF VSI ID")

We can take these too, it's your choice, which do you want us to do?

thanks,

greg k-h

Re: Fix Intel's ice driver in stable

[Jacob Keller]

On 5/15/2024 10:46 PM, Greg KH wrote:
> On Thu, May 16, 2024 at 05:12:40AM +0000, Samudrala, Sridhar wrote:
>> We need to fix this ASAP. Flipkart reported this issue with 6.1.x stable kernel.
>> Not sure why this commit was backported to LTS kernel as it is not a bug fix, but introduced as part of enabling live migration.
> 
> Back in March you were notified this was going to be picked up for the
> stable tree as part of the AUTOSEL work:
> 	https://lore.kernel.org/r/20240329122652.3082296-63-sashal@kernel.org
> 
> Any reason this wasn't noticed then?
> 
> thanks,
> 
> greg k-h

I saw this patch go by but didn't notice that the other two weren't
selected. The patches were sent as a series and tested as a series. The
dependency on the other changes was likely not noticed.

Re: Fix Intel's ice driver in stable

[Jacob Keller]

On 5/15/2024 11:44 PM, Greg KH wrote:
> On Wed, May 15, 2024 at 03:16:39PM -0600, Ahmed Zaki wrote:
>> 2 - applying the following upstream commits (part of the series):
>>  a) a21605993dd5dfd15edfa7f06705ede17b519026 ("ice: pass VSI pointer into
>> ice_vc_isvalid_q_id")
>>  b) 363f689600dd010703ce6391bcfc729a97d21840 ("ice: remove unnecessary
>> duplicate checks for VF VSI ID")
> 
> We can take these too, it's your choice, which do you want us to do?
> 
> thanks,
> 

Please pick these two up. That will solve the regression.

Thanks,
Jake

> greg k-h

Re: Fix Intel's ice driver in stable

[Greg KH]

On Thu, May 16, 2024 at 10:10:07AM -0700, Jacob Keller wrote:
> 
> 
> On 5/15/2024 11:44 PM, Greg KH wrote:
> > On Wed, May 15, 2024 at 03:16:39PM -0600, Ahmed Zaki wrote:
> >> 2 - applying the following upstream commits (part of the series):
> >>  a) a21605993dd5dfd15edfa7f06705ede17b519026 ("ice: pass VSI pointer into
> >> ice_vc_isvalid_q_id")
> >>  b) 363f689600dd010703ce6391bcfc729a97d21840 ("ice: remove unnecessary
> >> duplicate checks for VF VSI ID")
> > 
> > We can take these too, it's your choice, which do you want us to do?
> > 
> > thanks,
> > 
> 
> Please pick these two up. That will solve the regression.

Now picked up, thanks.

greg k-h

RE: Fix Intel's ice driver in stable

[Keller, Jacob E]

> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Wednesday, May 22, 2024 8:45 AM
> To: Keller, Jacob E <jacob.e.keller@intel.com>
> Cc: Zaki, Ahmed <ahmed.zaki@intel.com>; stable@vger.kernel.org; Nguyen,
> Anthony L <anthony.l.nguyen@intel.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@intel.com>; Chittim, Madhu <madhu.chittim@intel.com>;
> Samudrala, Sridhar <sridhar.samudrala@intel.com>
> Subject: Re: Fix Intel's ice driver in stable
> 
> On Thu, May 16, 2024 at 10:10:07AM -0700, Jacob Keller wrote:
> >
> >
> > On 5/15/2024 11:44 PM, Greg KH wrote:
> > > On Wed, May 15, 2024 at 03:16:39PM -0600, Ahmed Zaki wrote:
> > >> 2 - applying the following upstream commits (part of the series):
> > >>  a) a21605993dd5dfd15edfa7f06705ede17b519026 ("ice: pass VSI pointer
> into
> > >> ice_vc_isvalid_q_id")
> > >>  b) 363f689600dd010703ce6391bcfc729a97d21840 ("ice: remove
> unnecessary
> > >> duplicate checks for VF VSI ID")
> > >
> > > We can take these too, it's your choice, which do you want us to do?
> > >
> > > thanks,
> > >
> >
> > Please pick these two up. That will solve the regression.
> 
> Now picked up, thanks.
> 
> greg k-h

Thanks Greg!

-Jake