From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Josef Bacik <jbacik@fb.com>, Yu Kuai <yukuai3@huawei.com>,
Markus Pargmann <mpa@pengutronix.de>,
stable@vger.kernel.org
Subject: Re: [PATCH 5/5] nbd: Fix signal handling
Date: Mon, 20 May 2024 14:41:37 +0200 [thread overview]
Message-ID: <20240520124137.GA30199@lst.de> (raw)
In-Reply-To: <20240510202313.25209-6-bvanassche@acm.org>
On Fri, May 10, 2024 at 01:23:13PM -0700, Bart Van Assche wrote:
> Both nbd_send_cmd() and nbd_handle_cmd() return either a negative error
> number or a positive blk_status_t value.
Eww. Please split these into separate values instead. There is a reason
why blk_status_t is a separate type with sparse checks, and drivers
really shouldn't do avoid with that for a tiny micro-optimization of
the calling convention (if this even is one and not just the driver
being sloppy).
next prev parent reply other threads:[~2024-05-20 12:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240510202313.25209-1-bvanassche@acm.org>
2024-05-10 20:23 ` [PATCH 5/5] nbd: Fix signal handling Bart Van Assche
2024-05-20 12:41 ` Christoph Hellwig [this message]
2024-05-20 17:00 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240520124137.GA30199@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=jbacik@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=stable@vger.kernel.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox